hotspot
hotspot copied to clipboard
KDAB
Diff view
The description of the table is not correct and the data might be a bit crappy
The description of the table is not correct and the data might be a bit crappy
is this still open or did you fix it now?
I know I still need to update the test files, but the approach taken to create the diff view should be better now.
I tried adding diffing to the perfparser, but I don't know if this is the right way. Please tell me if the current way is acceptable or if I should try another one.
I changed the behavior to match perf diff -c ratio
Things to do:
- fix caller callee in diff mode
- maybe hide some views (like flamegraph, don't know how useful it is in this mode)
I tried this out now, there are multiple issues I see with this:
- it's nowhere clear what exactly the "ratio" cost means, can you add a tooltip to the header at least somehow?
- when looking at
perf.datafiles recorded with off-cpu cost, then the secondary costs' ratio values always show the same values as for the first one (cycles) - on the summary page, it would be great to show the summary for both files to be able to see the difference there already, with deltas
- opening the diff view is quasi impossible, as only the main view shows the button. we need an action in the File menu and also a way to trigger this view from the command line like in heaptrack, i.e.
hotspot -d perf.data.old perf.data - in the flame graph view I see nothing for the "ratio", except for the primary cost (cycles) - but ratio of e.g. sched switch is empty
Other than the missing tests the docs would need an update. If I knew how to test that locally and there's a CI build providing an AppImage of this I'd give this a test.
