GammaRay icon indicating copy to clipboard operation
GammaRay copied to clipboard

Upgrade QML Connections {} syntax to functions

Open ratijas opened this issue 2 years ago • 5 comments

Old signal handler declaration style is deprecated and spits warnings at runtime.

ratijas avatar Feb 03 '22 20:02 ratijas

This will likely break backward compatibility with older Qt5 versions, wont it? (GammaRay supports Qt5 back to 5.5).

5.5? oh. Is that something that still exists?

Likely will break then. But the current approach is surely broken for Qt 6, isn't it?

ratijas avatar Feb 09 '22 11:02 ratijas

QtLocation is gone in Qt6, so this entire thing doesn't work there anyway.

vkrause avatar Feb 09 '22 12:02 vkrause

At least Widget Inspector is still legit, I guess

ratijas avatar Feb 09 '22 12:02 ratijas

Personally I think it would be fine to upgrade to a newer Qt version nowadays, no? If people want a gammaray that works against Qt 5.5, they can use an older release.

milianw avatar Jun 17 '22 15:06 milianw

Personally I think it would be fine to upgrade to a newer Qt version nowadays, no?

Too early. The KDE Frameworks are not yet fully ported to Qt6, so application styling UX would be rather suboptimal on Linux platform.

If people want a gammaray that works against Qt 5.5, they can use an older release.

So a GammaRay build against Qt6 could still inspect apps running on Qt5? That would be great. Never tried (I think?)

ratijas avatar Jun 17 '22 16:06 ratijas

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 02 '23 12:06 CLAassistant

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

I did, some time ago. And my contributions were already merged in GammaRay in past.

ratijas avatar Jun 02 '23 12:06 ratijas

So a GammaRay build against Qt6 could still inspect apps running on Qt5? That would be great. Never tried (I think?)

No, that's not possible because GammaRay injects itself into the program, this is even a problem for same major version but different minor ie Qt6.2 GammaRay vs Qt6.4 App, for best compat you should use that exact same version, so I agree with @milianw that we could drop 5.5, but iirc this warning came around 5.14 or so... 5.14 indeed according to https://doc.qt.io/archives/qt-5.14/qml-qtqml-connections.html

dantti avatar Aug 25 '23 03:08 dantti

@ratijas Will need a manual rebase now, looks like some stuff was shuffled.

redstrate avatar Nov 02 '23 02:11 redstrate

@ratijas now that min required version is 5.15 could you please rebase this?

dantti avatar Dec 26 '23 19:12 dantti

no problem!

ratijas avatar Dec 26 '23 22:12 ratijas

image

AAAAAaaaa how is this a valid syntax

ratijas avatar Dec 26 '23 22:12 ratijas

Widget inspector was removed, so it's not relevant anymore.

ratijas avatar Dec 26 '23 22:12 ratijas