GammaRay icon indicating copy to clipboard operation
GammaRay copied to clipboard

Remove the 3D widget inspector view

Open vkrause opened this issue 3 years ago • 2 comments

This is causing trouble both with recent glslang versions as well as with Qt6, while offering few practical benefits to justify the effort.

Issue #635

vkrause avatar Jun 08 '21 10:06 vkrause

this isn't enough:

[6/163] Generating passthrough.vert_normals.geom_normals.frag_validate_program_4.stamp
FAILED: plugins/qt3dinspector/geometryextension/gl3/passthrough.vert_normals.geom_normals.frag_validate_program_4.stamp 
cd /home/milian/projects/kdab/rnd/gammaray/build-asan/plugins/qt3dinspector/geometryextension/gl3 && /usr/bin/glslangValidator -l /home/milian/projects/kdab/rnd/gammaray/plugins/qt3dinspector/geometryextension/gl3/passthrough.vert /home/milian/projects/kdab/rnd/gammaray/plugins/qt3dinspector/geometryextension/gl3/normals.geom /home/milian/projects/kdab/rnd/gammaray/plugins/qt3dinspector/geometryextension/gl3/normals.frag && /usr/bin/cmake -E touch /home/milian/projects/kdab/rnd/gammaray/build-asan/plugins/qt3dinspector/geometryextension/gl3/passthrough.vert_normals.geom_normals.frag_validate_program_4.stamp
/home/milian/projects/kdab/rnd/gammaray/plugins/qt3dinspector/geometryextension/gl3/passthrough.vert
/home/milian/projects/kdab/rnd/gammaray/plugins/qt3dinspector/geometryextension/gl3/normals.geom
/home/milian/projects/kdab/rnd/gammaray/plugins/qt3dinspector/geometryextension/gl3/normals.frag
ERROR: Linking vertex stage: Types must match:
    anon@0: " out block{ gl_Position 4-component vector of float Position gl_Position,  gl_PointSize float PointSize gl_PointSize,  out 1-element array of float ClipDistance gl_ClipDistance,  gl_ClipVertex 4-component vector of float ClipVertex gl_ClipVertex,  out 4-component vector of float FrontColor gl_FrontColor,  out 4-component vector of float BackColor gl_BackColor,  out 4-component vector of float FrontSecondaryColor gl_FrontSecondaryColor,  out 4-component vector of float BackSecondaryColor gl_BackSecondaryColor,  out 1-element array of 4-component vector of float TexCoord gl_TexCoord,  out float FogFragCoord gl_FogFragCoord}" versus gl_in: " in 1-element array of block{ in 4-component vector of float Position gl_Position,  in float PointSize gl_PointSize,  in 1-element array of float ClipDistance gl_ClipDistance}"

[7/163] Generating wireframe.vert_wireframe.geom_wireframe.frag_validate_program_5.stamp
FAILED: plugins/qt3dinspector/geometryextension/gl3/wireframe.vert_wireframe.geom_wireframe.frag_validate_program_5.stamp 
cd /home/milian/projects/kdab/rnd/gammaray/build-asan/plugins/qt3dinspector/geometryextension/gl3 && /usr/bin/glslangValidator -l /home/milian/projects/kdab/rnd/gammaray/plugins/qt3dinspector/geometryextension/gl3/wireframe.vert /home/milian/projects/kdab/rnd/gammaray/plugins/qt3dinspector/geometryextension/gl3/wireframe.geom /home/milian/projects/kdab/rnd/gammaray/plugins/qt3dinspector/geometryextension/gl3/wireframe.frag && /usr/bin/cmake -E touch /home/milian/projects/kdab/rnd/gammaray/build-asan/plugins/qt3dinspector/geometryextension/gl3/wireframe.vert_wireframe.geom_wireframe.frag_validate_program_5.stamp
/home/milian/projects/kdab/rnd/gammaray/plugins/qt3dinspector/geometryextension/gl3/wireframe.vert
/home/milian/projects/kdab/rnd/gammaray/plugins/qt3dinspector/geometryextension/gl3/wireframe.geom
/home/milian/projects/kdab/rnd/gammaray/plugins/qt3dinspector/geometryextension/gl3/wireframe.frag
ERROR: Linking vertex stage: Types must match:
    anon@0: " out block{ gl_Position 4-component vector of float Position gl_Position,  gl_PointSize float PointSize gl_PointSize,  out 1-element array of float ClipDistance gl_ClipDistance,  gl_ClipVertex 4-component vector of float ClipVertex gl_ClipVertex,  out 4-component vector of float FrontColor gl_FrontColor,  out 4-component vector of float BackColor gl_BackColor,  out 4-component vector of float FrontSecondaryColor gl_FrontSecondaryColor,  out 4-component vector of float BackSecondaryColor gl_BackSecondaryColor,  out 1-element array of 4-component vector of float TexCoord gl_TexCoord,  out float FogFragCoord gl_FogFragCoord}" versus gl_in: " in 3-element array of block{ in 4-component vector of float Position gl_Position,  in float PointSize gl_PointSize,  in 1-element array of float ClipDistance gl_ClipDistance}"

[8/163] Generating skybox.vert_skybox.frag_validate_program_6.stamp
/home/milian/projects/kdab/rnd/gammaray/plugins/qt3dinspector/geometryextension/gl3/skybox.vert
/home/milian/projects/kdab/rnd/gammaray/plugins/qt3dinspector/geometryextension/gl3/skybox.frag

milianw avatar Jun 08 '21 10:06 milianw

this isn't enough:

yeah, qt3dinspector needs to be skipped as well. Not sure if thats remove-worthy or not though.

shaan7 avatar Jun 17 '21 17:06 shaan7

closing this. I committed (along with a few other glslang-related fixes) in fbbe675b4b74903b38d6dc4a7a2c14d528d1cdab

winterz avatar Oct 21 '22 20:10 winterz