Build issue with glslang 11.4.0

[krop]

Gammaray fails to build on openSUSE since a recent update from 11.2.0 to 11.4.0. error log below:

[   86s] [  2%] Generating widget_wireframe.frag_widget_wireframe.geom_widget_wireframe.vert_validate_program_3.stamp
[   86s] cd /home/abuild/rpmbuild/BUILD/gammaray-2.11.2/build/plugins/widgetinspector/assets/shaders && /usr/bin/glslangValidator -l /home/abuild/rpmbuild/BUILD/gammaray-2.11.2/plugins/widgetinspector/assets/shaders/widget_wireframe.frag /home/abuild/rpmbuild/BUILD/gammaray-2.11.2/plugins/widgetinspector/assets/shaders/widget_wireframe.geom /home/abuild/rpmbuild/BUILD/gammaray-2.11.2/plugins/widgetinspector/assets/shaders/widget_wireframe.vert
[   86s] /home/abuild/rpmbuild/BUILD/gammaray-2.11.2/plugins/widgetinspector/assets/shaders/widget_wireframe.frag
[   86s] /home/abuild/rpmbuild/BUILD/gammaray-2.11.2/plugins/widgetinspector/assets/shaders/widget_wireframe.geom
[   86s] /home/abuild/rpmbuild/BUILD/gammaray-2.11.2/plugins/widgetinspector/assets/shaders/widget_wireframe.vert
[   86s] ERROR: Linking vertex stage: Types must match:
[   86s]     anon@0: " out block{ gl_Position 4-component vector of float Position gl_Position,  gl_PointSize float PointSize gl_PointSize,  out 1-element array of float ClipDistance gl_ClipDistance,  gl_ClipVertex 4-component vector of float ClipVertex gl_ClipVertex,  out 4-component vector of float FrontColor gl_FrontColor,  out 4-component vector of float BackColor gl_BackColor,  out 4-component vector of float FrontSecondaryColor gl_FrontSecondaryColor,  out 4-component vector of float BackSecondaryColor gl_BackSecondaryColor,  out 1-element array of 4-component vector of float TexCoord gl_TexCoord,  out float FogFragCoord gl_FogFragCoord}" versus gl_in: " in 3-element array of block{ in 4-component vector of float Position gl_Position,  in float PointSize gl_PointSize,  in 1-element array of float ClipDistance gl_ClipDistance}"
[   86s] 
[   86s] make[2]: *** [plugins/widgetinspector/assets/shaders/CMakeFiles/widget_wireframe.frag_widget_wireframe.geom_widget_wireframe.vert_validate_program_3.dir/build.make:78: plugins/widgetinspector/assets/shaders/widget_wireframe.frag_widget_wireframe.geom_widget_wireframe.vert_validate_program_3.stamp] Error 3

[winterz]

This is a bug with glslang. We encountered this in our internal CI too. I backed-off the version to glslang 11.1.0

[krop]

Well, I didn't find any other package that fails to build due to this update.

[vkrause]

Since this is not the first time this comes up, and since this code is also proving annoying to migrate to Qt6, I'd suggest to remove that entire feature, unless someone comes up with a better idea or a valid objection why we definitely need to keep this.

[seanharmer]

For reference, this is the upstream bug https://github.com/KhronosGroup/glslang/issues/2578

[krop]

Sadly, this report didn't get much attention before and after the 11.4.0 release

[trmdi]

Is it safe to disable glslang temporarily? https://build.opensuse.org/request/show/898231

[winterz]

Is it safe to disable glslang temporarily? https://build.opensuse.org/request/show/898231

Yes, should be safe.

[winterz]

for the record gammaray version 2.11 is the end of the 2.x series and we don't plan to make any more changes/releases

for the next major release (3.0 , master branch) I plan to remove glslang feature.