GammaRay icon indicating copy to clipboard operation
GammaRay copied to clipboard

Signal inspector optimizations and improvements

Open pasnox opened this issue 7 years ago • 2 comments

pasnox avatar Jun 23 '17 11:06 pasnox

Indeed my metrics is not really accurate, just checked the cpu usage, and when you pass from 120% usage to 60% i guess you can trust it a bit ;) I will try to add some benchmarks, though I did not yet played with that thing.

pasnox avatar Jun 26 '17 07:06 pasnox

I'm not debating that the patches have a good influence on the performance overall. I'm just saying that some patches are dubious. And you need to better explain what metric you are using to justify the patches. From what I now gather, you looked at the CPU time in the Mac-equivalent of "top"? That is super inaccurate on its own. But more importantly, this means that you have had to "setup" GammaRay and whichever test application you used manually everytime between the measurements, making the measurement even more inaccurate.

Please, at least use a CPU profiler like Instruments to do the measurement. Then you can hopefully make some more accurate statements on individual functions.

milianw avatar Jun 26 '17 08:06 milianw

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 02 '23 12:06 CLAassistant