GammaRay icon indicating copy to clipboard operation
GammaRay copied to clipboard

Export the launcher dialog as a shared library

Open giucam opened this issue 7 years ago • 3 comments

This is to be used in the qtcreator plugin instead of the custom dialog.

giucam avatar Feb 09 '17 08:02 giucam

When reviewing this I found it hard to reason about the dependencies in the launcher code, so I have shuffled the code around a bit and integrated the part of this change creating a shared library for the UI components (see wip/launcher-refactor branch).

Once that is merged we can rebase this change on top and should only be left with the API changes. I'm surprised though that there are no exports added in this change, which classes are actually needed in QtCreator in the end?

vkrause avatar Apr 04 '17 13:04 vkrause

I had forgotten to add the files with the new LauncherDialog class, which is the glue that was missing.

giucam avatar Apr 05 '17 12:04 giucam

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jun 02 '23 12:06 CLAassistant