DeclarativeWidgets icon indicating copy to clipboard operation
DeclarativeWidgets copied to clipboard

Have created loader items inherit the parent context

Open Znurre opened this issue 6 years ago • 7 comments

The current behavior for LoaderWidget seems to differ from that of Loader in that components loaded by Loader will have access to the parent context's properties while items loaded by LoaderWidget will only have access to the root context's properties. This change attempts to unify the behavior and have LoaderWidget behave the same way as Loader.

Znurre avatar Feb 18 '18 18:02 Znurre

Hi Znurre,

thank you for your contributions. We'll take a look and get back to you by the end of the month.

Kind regards, Nathan

0x6e avatar Feb 20 '18 09:02 0x6e

Hi Znurre,

before we can accept your contributions to DeclarativeWidgets we will need a signed Copyright Assignment form from you, and if you are employed we will also need your employer to sign the Disclaimer part of the agreement. The form is attached to this comment, and includes instructions detailing what you need to do.

Kind regards, Nathan

KDAB-CopyrightAssignmentForm.docx

0x6e avatar Feb 27 '18 11:02 0x6e

Hi Nathan,

I've sent a signed Copyright Assignment form to the e-mail address specified in the form 8 days ago, but without any reply so far.

Best regards, Lova

Znurre avatar Mar 20 '18 06:03 Znurre

Hi Lova,

I'll chase it up, thanks for letting me know.

Kind regards, Nathan

0x6e avatar Mar 20 '18 09:03 0x6e

Hi Lova,

we haven't been able to find the e-mail you sent. Could you please resend it to [email protected]

Kind regards, Nathan

0x6e avatar Mar 20 '18 11:03 0x6e

Having support for Repeater would be so great, since we could then use a widgets-based view on a data model. Unfortunately, it appears this pull request got a little messy since unrelated commits were pushed to the source branch after the review was approved. Is there chance of still getting this merged?

bjorn avatar Jul 05 '21 09:07 bjorn

I am not sure why I never got around to merging this. To be honest, I thought I did, but I guess not. If time permits, I will have a look at changing this PR to target another branch of my repo and prepare that for submission as per the scope of the original PR.

Znurre avatar Jul 05 '21 13:07 Znurre