VAL icon indicating copy to clipboard operation
VAL copied to clipboard

Forbidden parameter name: ?after

Open haz opened this issue 2 years ago • 4 comments

This is kind of a weird one...it appears as though VAL (and thus the VSCode extension) complains when we use ?after as a parameter:

image

Any idea what might be going on, @jan-dolejsi ?

haz avatar Feb 17 '23 19:02 haz

More examples of when it's fine...

image

image

haz avatar Feb 17 '23 19:02 haz

This may be because "after" is a keyword in PDDL preferences syntax. (This shouldn't class with "?after", but perhaps VAL mixes these namespaces.)

maltehelmert avatar Feb 21 '23 15:02 maltehelmert

Malte is right - the tokenizer turns that into a token before the parser gets to see the token stream, so it is already miscategorised as a keyword before it gets to yacc. I can have a look at modifying this behaviour, but in general the keywords will not work as strings for variables, constants, actions, predicates or functions.


From: Christian Muise @.> Sent: 17 February 2023 19:57 To: KCL-Planning/VAL @.> Cc: Subscribed @.***> Subject: [KCL-Planning/VAL] Forbidden parameter name: ?after (Issue #59)

This is kind of a weird one...it appears as though VAL (and thus the VSCode extension) complains when we use ?after as a parameter:

[image]https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F225019%2F219779239-927e71a9-eced-42ec-8353-4aa8a538b842.png&data=05%7C01%7Cderek.long%40kcl.ac.uk%7C3cede31d71b64877ebfc08db11213ab6%7C8370cf1416f34c16b83c724071654356%7C0%7C0%7C638122606633571437%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=mHPz%2F5CWjfQeUjHkU1by%2BNHPLDg81ROYHjV89hTGxdw%3D&reserved=0

Any idea what might be going on, @jan-dolejsihttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjan-dolejsi&data=05%7C01%7Cderek.long%40kcl.ac.uk%7C3cede31d71b64877ebfc08db11213ab6%7C8370cf1416f34c16b83c724071654356%7C0%7C0%7C638122606633571437%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=agr6Lz6UMZGUYZHUxxAG6XwtpnRFSfHuj6YKuCK6frQ%3D&reserved=0 ?

— Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FKCL-Planning%2FVAL%2Fissues%2F59&data=05%7C01%7Cderek.long%40kcl.ac.uk%7C3cede31d71b64877ebfc08db11213ab6%7C8370cf1416f34c16b83c724071654356%7C0%7C0%7C638122606633571437%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=neVGVQ7wNor301Hk%2F9ynPv%2BAYNdYnE%2FTtbnLH%2B1FAH4%3D&reserved=0, or unsubscribehttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAB2KOVB6OHVC4NA4SVU74GDWX7J3JANCNFSM6AAAAAAU72BCRA&data=05%7C01%7Cderek.long%40kcl.ac.uk%7C3cede31d71b64877ebfc08db11213ab6%7C8370cf1416f34c16b83c724071654356%7C0%7C0%7C638122606633571437%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=RrvGXPYMbBB9tYq2pG3eBCoLwu%2BbZVnsHUBwwbkYrHs%3D&reserved=0. You are receiving this because you are subscribed to this thread.Message ID: @.***>

DerekLong101 avatar Feb 21 '23 16:02 DerekLong101

Thanks, both! Even a more descriptive error message would be helpful in this situation (was very much unclear what was wrong with the original action).

What's wild about this one is that it's from an actual IPC domain, and not just a student submission from one of my courses.

haz avatar Feb 21 '23 18:02 haz