VAL icon indicating copy to clipboard operation
VAL copied to clipboard

Parsing plans with over 9994 steps fails with "Bad plan description!"

Open FlorianPommerening opened this issue 7 years ago • 1 comments

I tried to upload the attached plan (sas_plan.txt) to planning.domains problem 4275 (Towers of Hanoi with 15 disks and 3 pegs). The solution is 2^15-1 = 32767 steps long which seems to be a problem for the parser. I tried removing steps and found that the plan is rejected if it contains 9995 steps or more.

I suspect that this has to do with the stack depth of yacc, which is set to 10000 in pddl+.cpp and pddlplus.cpp. Since the grammar of plans is recursive, this means that long plans cannot be parsed.

FlorianPommerening avatar May 26 '17 11:05 FlorianPommerening

Thanks Flogo. I am sure you are right that this is the yacc limit. I am not sure that this is a priority issue - but I wiĺ see what is required to fix it.

Sent from Samsung tablet. -------- Original message --------From: flogo [email protected] Date: 26/05/2017 12:57 (GMT+00:00) To: KCL-Planning/VAL [email protected] Cc: Subscribed [email protected] Subject: [KCL-Planning/VAL] Parsing plans with over 9994 steps fails with "Bad plan description!" (#16) I tried to upload the attached plan (sas_plan.txt) to planning.domains problem 4275 (Towers of Hanoi with 15 disks and 3 pegs). The solution is 2^15-1 = 32767 steps long which seems to be a problem for the parser. I tried removing steps and found that the plan is rejected if it contains 9995 steps or more. I suspect that this has to do with the stack depth of yacc, which is set to 10000 in pddl+.cpp and pddlplus.cpp. Since the grammar of plans is recursive, this means that long plans cannot be parsed.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/KCL-Planning/VAL","title":"KCL-Planning/VAL","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/KCL-Planning/VAL"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Parsing plans with over 9994 steps fails with "Bad plan description!" (#16)"}],"action":{"name":"View Issue","url":"https://github.com/KCL-Planning/VAL/issues/16"}}}

DerekLong101 avatar May 26 '17 18:05 DerekLong101