ROSPlan icon indicating copy to clipboard operation
ROSPlan copied to clipboard

Noetic devel

Open oscar-lima opened this issue 4 years ago • 10 comments

changes for ROSPlan to run in noetic

oscar-lima avatar Nov 09 '20 14:11 oscar-lima

Great Work Oscar. For making ROSplan work for noetic. Is something missing because the build is breaking?

harshkakashaniya avatar Jan 06 '21 16:01 harshkakashaniya

Great Work Oscar. For making ROSplan work for noetic. Is something missing because the build is breaking?

The problem is: cc1plus: error: -Werror=deprecated-copy: no option -Wdeprecated-copy I introduced a workaround which works on my PC, however it does not seem to work on the integration server, you can try on your PC, maybe you are lucky

oscar-lima avatar Jan 07 '21 02:01 oscar-lima

You are right !!! There are some warnings while it is been build. But it is working fine on my PC. Thank you ...

harshkakashaniya avatar Jan 07 '21 15:01 harshkakashaniya

Dear oscar, I had a question for you. can we add negative conditions in our problem file ?

Planner is not able to plan if I have a negative condition in problem file. for example: (not (docked kenney))

does not work ..

any solutions.

harshkakashaniya avatar Jan 14 '21 23:01 harshkakashaniya

Hi

It never makes sense to put negative facts in a problem file - PDDL uses the closed world assumption and, therefore, absence of a fact is the way you say the fact is false. Some planners, but not all, handle negative preconditions in the actions. POPF/OPTIC do not. There are solutions to this - the standard one is to "mirror" conditions. That is, when you want the condition (not (P)) as a precondition, you create the condition (notP) and add that as precondition. You now ensure that every action that adds P deletes notP and every action that deletes P adds notP. Another option is to try to find a planner that works with negative preconditions.

Cheers

Derek


From: Harsh Kakashaniya [email protected] Sent: 14 January 2021 23:50 To: KCL-Planning/ROSPlan [email protected] Cc: Subscribed [email protected] Subject: Re: [KCL-Planning/ROSPlan] Noetic devel (#268)

Dear oscar, I had a question for you. can we add negative conditions in our problem file ?

Planner is not able to plan if I have a negative condition in problem file. for example: (not (docked kenney))

does not work ..

any solutions.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FKCL-Planning%2FROSPlan%2Fpull%2F268%23issuecomment-760550386&data=04%7C01%7Cderek.long%40kcl.ac.uk%7C62381dcfb6c64db9506f08d8b8e73577%7C8370cf1416f34c16b83c724071654356%7C0%7C0%7C637462650482895678%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=IJvQkth4YgBKTogpnW6y8Fqr9SBTpEvVDRb9EViOHR0%3D&reserved=0, or unsubscribehttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAB2KOVGN6OEKT5F4ETXPQYLSZ57NHANCNFSM4TPNQMBQ&data=04%7C01%7Cderek.long%40kcl.ac.uk%7C62381dcfb6c64db9506f08d8b8e73577%7C8370cf1416f34c16b83c724071654356%7C0%7C0%7C637462650482905677%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=GG6XAt1KMVjnN6fpPd%2Ffr%2FD1tQW6k%2B6yTqqos0cnPdA%3D&reserved=0.

DerekLong101 avatar Jan 15 '21 10:01 DerekLong101

Dear Derek, Thank you very much for your detailed answer and export preaching. now I understood the thinking behind this. Everything makes much more sense now.

Regards, Harsh

harshkakashaniya avatar Jan 15 '21 16:01 harshkakashaniya

I am having issues with the sensing interface:

File "/home/hbk_il/Desktop/Integrated_ws/src/integratedcore/ROSPlan/rosplan_sensing_interface/scripts/sensing_interface.py", line 285 def subs_callback(self, msg, (pred_name, pred_info)): ^ SyntaxError: invalid syntax [rosplan_sensing_interface-7] process has died [pid 137784, exit code 1, cmd /home/hbk_il/Desktop/Integrated_ws/src/integratedcore/ROSPlan/rosplan_sensing_interface/scripts/sensing_interface.py __name:=rosplan_sensing_interface __log:=/home/hbk_il/.ros/log/a6dfdcea-6122-11eb-b76b-13b46bf4b6f3/rosplan_sensing_interface-7.log]. log file: /home/hbk_il/.ros/log/a6dfdcea-6122-11eb-b76b-13b46bf4b6f3/rosplan_sensing_interface-7*.log

harshkakashaniya avatar Jan 28 '21 04:01 harshkakashaniya

Hi @harshkakashaniya, I just opened a PR #277 to address the issue with the sensing interface. This will fix the issue you're experiencing, and it's due to Noetic using Python 3.

gerardcanal avatar Feb 03 '21 15:02 gerardcanal

Great Work Oscar. For making ROSplan work for noetic. Is something missing because the build is breaking?

The problem is: cc1plus: error: -Werror=deprecated-copy: no option -Wdeprecated-copy I introduced a workaround which works on my PC, however it does not seem to work on the integration server, you can try on your PC, maybe you are lucky

Hi @oscar-lima ,

Thanks for the noetic extension. I also faced problems building ROSPlan for noetic. I fixed it by adding -Wno-error in [1] in the rosplan_dependencies CMakeList.

[1] SET (RDDL_CMAKE_CXX_FLAGS "${RDDL_CMAKE_CXX_FLAGS} -g -Wall -W -Wno-sign-compare -Wno-deprecated -ansi -pedantic -Werror -std=c++11 -O3 -DNDEBUG -fomit-frame-pointer -Wno-error=deprecated-copy")

YanielCarreno avatar Apr 29 '22 09:04 YanielCarreno

Great Work Oscar. For making ROSplan work for noetic. Is something missing because the build is breaking?

The problem is: cc1plus: error: -Werror=deprecated-copy: no option -Wdeprecated-copy I introduced a workaround which works on my PC, however it does not seem to work on the integration server, you can try on your PC, maybe you are lucky

Hi @oscar-lima ,

Thanks for the noetic extension. I also faced problems building ROSPlan for noetic. I fixed it by adding -Wno-error in [1] in the rosplan_dependencies CMakeList.

[1] SET (RDDL_CMAKE_CXX_FLAGS "${RDDL_CMAKE_CXX_FLAGS} -g -Wall -W -Wno-sign-compare -Wno-deprecated -ansi -pedantic -Werror -std=c++11 -O3 -DNDEBUG -fomit-frame-pointer -Wno-error=deprecated-copy")

Tks for this !!

ViniciusAbrao avatar Oct 03 '23 14:10 ViniciusAbrao