ExeTera icon indicating copy to clipboard operation
ExeTera copied to clipboard

field filter array dereference

Open Liyuan-Chen-1024 opened this issue 2 years ago • 2 comments

fix #227

Liyuan-Chen-1024 avatar Jul 04 '22 13:07 Liyuan-Chen-1024

[] how to separate two cases: apply_filter, and apply_index? Should we use logic below: if filter_to_apply is boolean type, then [] will call apply_filter, otherwise, it will call apply_index?

Liyuan-Chen-1024 avatar Jul 04 '22 13:07 Liyuan-Chen-1024

Codecov Report

Merging #302 (6a6f15f) into master (bc66b84) will increase coverage by 0.04%. The diff coverage is 96.15%.

@@            Coverage Diff             @@
##           master     #302      +/-   ##
==========================================
+ Coverage   83.39%   83.43%   +0.04%     
==========================================
  Files          22       22              
  Lines        6191     6213      +22     
  Branches     1247     1252       +5     
==========================================
+ Hits         5163     5184      +21     
  Misses        733      733              
- Partials      295      296       +1     
Impacted Files Coverage Δ
exetera/core/fields.py 91.09% <95.83%> (+0.06%) :arrow_up:
exetera/core/dataframe.py 87.36% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 01 '22 12:09 codecov-commenter