Jan Bielecki

> > How about next to the max_cycles_per_dependency parameter we can introduce max_cycles_overall? It will allow for ASAP feedback if one executes the contract check with max_cycles_overall=1. > > Not...

@Peter554 what are your thoughts on having a high level method `find_cycles_between_siblings` implemented in Grimp with a signature that @seddonym suggested?

@seddonym I just have a second thoughts that the `max_cycles_per_dependency` parameter is maybe not the best parameter to reduce the search time. I dont think we are going to implement...

Oh, you wrote about it already. But what do you mean by "removing cycle from the graph"? If you remove any edge it can affect other cycles, not only the...

In such a case, we cannot guarantee that the method will return all the cycles. I am ok with that, but I think it should be underlined in the method...

I was reading Bob Uncle book and he mentioned "Acyclic dependencies principle" (https://en.wikipedia.org/wiki/Acyclic_dependencies_principle) which is exactly what I wanted to achieve through a "Tree contract" (https://github.com/seddonym/import-linter/pull/250). Btw. It should not...

Thanks @Peter554 for the comments. As you suggest, let's discuss the justification and a signature of the method before we go into more details. I started the conversation here: https://github.com/seddonym/grimp/issues/189#issuecomment-2676079736