K3D-jupyter icon indicating copy to clipboard operation
K3D-jupyter copied to clipboard

Installation instructions

Open renefritze opened this issue 1 year ago • 4 comments

The README mentions enabling the extensions. The docs do not mention that. From my understanding the manual enabling should indeed no longer be necessary. Is my understanding correct?

There's also an (I guess orphaned?) https://github.com/K3D-tools/K3D-jupyter/blob/main/postBuild which has the enabling in it.

renefritze avatar Sep 07 '22 11:09 renefritze

https://github.com/K3D-tools/K3D-jupyter/blob/main/environment.yml Should also no longer be used after the binder/ subdir was added, right?

renefritze avatar Sep 07 '22 11:09 renefritze

Between #371 and this (#373) I had a difficult time debugging. In my env (Debian 11 Docker, newest python/debian/etc) the line jupyter labextension install k3d would consistently fail, citing:

$ webpack --config webpack.prod.minimize.config.js
[webpack-cli] ModuleNotFoundError: Module not found: Error: Can't resolve 'k3d/dist/labplugin' in '/home/admin/venv_/share/jupyter/lab/staging/build'

I would have been fine, except I was also trying to deal with #371, and this threw me for a loop

tennysontbardwell avatar Sep 18 '22 16:09 tennysontbardwell

Between #371 and this (#373) I had a difficult time debugging. In my env (Debian 11 Docker, newest python/debian/etc) the line jupyter labextension install k3d would consistently fail, citing:

$ webpack --config webpack.prod.minimize.config.js
[webpack-cli] ModuleNotFoundError: Module not found: Error: Can't resolve 'k3d/dist/labplugin' in '/home/admin/venv_/share/jupyter/lab/staging/build'

I also see this in my stack: full log

renefritze avatar Sep 20 '22 12:09 renefritze

I have trouble with and without the labextension commands. When I perform an install, JupyterLab prompts me to perform a build, which the k3d extension always fails as above.

As of this week I also cannot seem to get the notebook extension to work anymore.

oursland avatar Sep 20 '22 23:09 oursland

Please try 2.15.0 (https://pypi.org/project/k3d/ for conda-forge we need to wait a little bit). @renefritze contribution should solve that

https://github.com/K3D-tools/K3D-jupyter/blob/main/environment.yml Should also no longer be used after the binder/ subdir was added, right?

It should not. I will try to remove it soon.

The README mentions enabling the extensions. The docs do not mention that. From my understanding the manual enabling should indeed no longer be necessary. Is my understanding correct?

There's also an (I guess orphaned?) https://github.com/K3D-tools/K3D-jupyter/blob/main/postBuild which has the enabling in it.

I'm not sure. Probably if you are using conda it is not. In case of pip probably enabling extension is mandatory.

artur-trzesiok avatar Dec 16 '22 17:12 artur-trzesiok

While working on #386 I found that both for jupyterlab and classic notebook extensions do not need to be manually enabled .

renefritze avatar Dec 16 '22 17:12 renefritze

Great! So We should remove instructions from readm.md then!

artur-trzesiok avatar Dec 16 '22 18:12 artur-trzesiok

@renefritze do you think that we can close that issue?

artur-trzesiok avatar Dec 18 '22 00:12 artur-trzesiok

Yeah. Thanks!

renefritze avatar Dec 19 '22 08:12 renefritze