rulerz icon indicating copy to clipboard operation
rulerz copied to clipboard

Fixes a bug where you cannot use a runtime operator in a SQL query

Open iainmckay opened this issue 7 years ago • 4 comments

This attempts to fix the bug documented in #40. As you stated, it wasn't a trivial fix and our fix is, unfortunately, a bit disruptive.

This introduces a few new objects to track what type of operators are being created so that they can be formatted correctly when they are written out to a cache. Breaking out of strings is a bit messy but it was the most straightforward method we could find to solve the issue.

We've only confirmed that the native and DoctrineORM targets work right now as that is what we use in our project. I'd like feedback on our approach but we do intend on fixing the other targets and tests to work.

iainmckay avatar May 26 '17 08:05 iainmckay

I just drop a quick comment to say that I saw your PR and will definitely review it, but that I won't be able to do it before at least a couple of weeks (due to a lack of time).

Thanks for the PR and sorry for the inconvenience :|

K-Phoen avatar Jun 02 '17 15:06 K-Phoen

Sure. It's not in a state that can be merged it was more to see if you agreed with the general approach then we'll wrap it up.

iainmckay avatar Jun 02 '17 15:06 iainmckay

Do you have any feedback on this?

iainmckay avatar Sep 19 '17 11:09 iainmckay

Ping

iainmckay avatar Jan 09 '18 10:01 iainmckay