eti-stuff icon indicating copy to clipboard operation
eti-stuff copied to clipboard

RTL-TCP: Make it visible and rearrange command-line help

Open lars18th opened this issue 7 years ago • 3 comments

This is based on the issue #27 .

lars18th avatar Mar 06 '18 11:03 lars18th

Would not it be better - if you insist of having RTL_TCP input documented - to add descriptions for how to specify address and port

JvanKatwijk avatar Mar 06 '18 12:03 JvanKatwijk

Hi @JvanKatwijk ,

Would not it be better - if you insist of having RTL_TCP input documented - to add descriptions for how to specify address and port

I'm not sure of your request. Please see this (although I feel like you already know):

  • The current DOCUMENTATION has it: http://github.com/JvanKatwijk/eti-stuff/blob/master/eti-cmdline/README.md --> Section "Command line parameters/For use with rtl_tcp"
  • Help inside the binary added: https://github.com/lars18th/eti-stuff/blob/rtl-tcp/eti-cmdline/main.cpp#L442

I don't know what more I need to describe. Perhaps an example?

In any case, the PR contains more than only RTL_TCP stuff. An I hope you agree to commit it. :smile:

lars18th avatar Mar 06 '18 12:03 lars18th

Hi @JvanKatwijk ,

From my point of view this patch is finished. Please, review it. I feel I do all required cleans. If you think I missed something, let me know.

Regards.

lars18th avatar Mar 07 '18 11:03 lars18th