Adorn icon indicating copy to clipboard operation
Adorn copied to clipboard

Drawers create a hole in the floor and sides of other blocks (Screenshot attached) / Sodium - Iris - Continuity - CITResewn etc.

Open OkinawaGaijin opened this issue 1 year ago • 4 comments

Adorn version

3.6.1+1.19

Minecraft version

1.19.2

Mod loader

Fabric

Mod loader version

Fabric Loader 0.14.9 - Fabric Api 0.60.0+1.19.2

Describe the bug

Using the Oak Drawer, it removes a 4x16 pixel part of any floor directly below the protruding drawers, revealing the map below. They also remove sideparts of blocks next to them (look at the kitchen counter top next to the drawer to the left)

Running the game with Sodium / Iris (latest as of August 30) and using all recommended / required mods like Continuity and CITResewn to mimic Optifine capabilities. No other issues have been found so far with Adorn.

Placed the drawer on different surfaces and the result is the same, part of the blocks below disappear.

2022-08-30_19 22 59

To reproduce

Just place the Drawer block somewhere.

I have not tested any other than the Oak Drawers, but I suspect the results to be the same for other types.

Game logs

No response

Additional context

No response

OkinawaGaijin avatar Aug 30 '22 10:08 OkinawaGaijin

Thanks for the detailed bug report, I'll look into this. I suspect it's one of the rendering mods affecting the drawer rendering since it works normally without them.

Juuxel avatar Aug 30 '22 11:08 Juuxel

I couldn't reproduce this with the mods mentioned in your description:

  • Adorn+Fabric API+Fabric Language Kotlin
  • Sodium
  • Indium (needed for Continuity)
  • Iris
  • Continuity
  • CIT Resewn

Could you share your full mod list?

Juuxel avatar Aug 30 '22 11:08 Juuxel

I see. Be aware I'm using a total of 301 mods according to the main menu message. This also includes Immersive Portals, which currently has another huge bug when paired with Sodium. As long as I run a shaderpack on Iris, nothing happens, but if I turn the shaderpack off, the game crashes.

So I can't test the Adorn issue with shaderpacks turned off unless I disable ImmersivePortals

Several people who only use Sodium and Immersive Portal have already reported similar issues with crashlogs looking similar to mine.

Maybe it's not too far fetched to assume that the immersive portal mod is also somehow messing with the rendering related to your drawers.

I will give you my full modlist just to be on the safe side. Maybe you know of an incompatibility I missed. I also added in the Shaderpack and Resource Pack listing provided by one of my (unrelated) crash logs, just so you can see those too. Just note that I had the same issue without any resource packs touching vanilla textures too.

Modlist_Latest.txt

OkinawaGaijin avatar Aug 30 '22 12:08 OkinawaGaijin

Well, immersive portals updated to adapt to the latest Sodium version. The crash when trying to run them together without an Iris shader is gone.

But the drawer still looks botched.

But don't bother. With that long as hell modlist I'm running, there's bound to be some conflict that's causing it. I don't expect you to search for it. I'm not in the mood to A-B-Test my 300 mods either.

It's not a game-breaking issue, so I'll live with it.

OkinawaGaijin avatar Aug 30 '22 17:08 OkinawaGaijin

I already sent the issue to the creator of moreculling, it happens with the moreculling mod, if you disable the option in the video settings it goes back to normal

https://github.com/fxmorin/MoreCulling/issues/92

lostopkk avatar Sep 20 '22 01:09 lostopkk

Ah, another MoreCulling issue. There's nothing I can do to fix it then.

Juuxel avatar Sep 20 '22 06:09 Juuxel

Could have given it the correct hitbox...

FxMorin avatar Dec 08 '22 21:12 FxMorin

The hitbox is intentional and the correct outline is the full block.

I set nonOpaque in the block settings which disables the culling in vanilla as expected for non-opaque blocks even if their outline shape is a full 1x1x1 cube, but MoreCulling breaks that behaviour.

Juuxel avatar Dec 08 '22 22:12 Juuxel

Ya, MoreCulling goes more aggressive by using more data & caching. Since vanilla correctly implements hitboxes for all blocks, I'm able to instead do hitbox calculations to further cull all the missing blocks. It's fine if you don't want to support it tho

FxMorin avatar Dec 09 '22 04:12 FxMorin

This will be fixed in Adorn 5.0.0, the next feature release.

Juuxel avatar Jun 18 '23 21:06 Juuxel

@Juuxel Any chance we’ll see this fix backported to 1.19.2?

rinebergc avatar Jun 23 '23 08:06 rinebergc