koap icon indicating copy to clipboard operation
koap copied to clipboard

Handle Oscore `partialIv`, `kidContext`, and `kid` explicitly

Open zalenskivolt opened this issue 9 months ago • 4 comments

zalenskivolt avatar Mar 31 '25 22:03 zalenskivolt

Codecov Report

:x: Patch coverage is 78.84615% with 11 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 69.61%. Comparing base (6cbf889) to head (d818bb2).

Files with missing lines Patch % Lines
koap-core/src/commonMain/kotlin/Oscore.kt 79.16% 9 Missing and 1 partial :warning:
koap-core/src/commonMain/kotlin/Message.kt 75.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
+ Coverage   69.04%   69.61%   +0.56%     
==========================================
  Files           9       10       +1     
  Lines         798      849      +51     
  Branches      217      236      +19     
==========================================
+ Hits          551      591      +40     
- Misses        161      171      +10     
- Partials       86       87       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Mar 31 '25 22:03 codecov[bot]

@zalenskivolt apologies; I've been busy on other work projects, but I plan to review this soon.

twyatt avatar Apr 22 '25 08:04 twyatt

@zalenskivolt apologies; I've been busy on other work projects, but I plan to review this soon.

no worries!

I had a bit of a break in my current work, which caused this flurry of 10 PRs 😄 but I'm also more back to other work projects now…

zalenskivolt avatar Apr 23 '25 10:04 zalenskivolt

Another take: instead of breaking up the option value into parts, just do that in the toString method, and optionally construct an Oscore option from the different parts, using Oscore.fromParts(partialIv, kidContext, kid)

zalenskivolt avatar Nov 12 '25 01:11 zalenskivolt