NGA-CLIENT-VER-OPEN-SOURCE icon indicating copy to clipboard operation
NGA-CLIENT-VER-OPEN-SOURCE copied to clipboard

Published 20 hours ago • verified publisher icon Justwen

Replace floatingactionmenu with FAB of Material Design

Open FantasqueX opened this issue 2 years ago • 4 comments

Currently, this project uses close-source floatingactionmenu.aar to provide floating action button. I think using FAB of Material Design is a better choice which can also resovle #82 .

If you agree with me, I'll send a patch.

FantasqueX avatar Jan 29 '23 16:01 FantasqueX

The aar has some extra modification which is lost and not include in this github project. I am not sure if it is ok to replace it by the github version

Justwen avatar Jan 30 '23 02:01 Justwen

I have tried to replace the aar with com.getbase.floatingactionbutton, however, some symbols cannot be found. I've made the change in my fork, you can check it here.

FantasqueX avatar Jan 30 '23 05:01 FantasqueX

Oh, we'd better not replace floatingactionmenu by fab the refresh icon is useful when multi pages are loaded, otherwise we need scroll to the top of this recycleview to refresh the it.

Justwen avatar Jan 30 '23 12:01 Justwen

Other APPs use fab such as gmail and outlook. They both face the problem like us. What's more, refreshing just likes "go to top" which is confusing in that place. Maybe we can make the title bar touchable to solve this problem.

FantasqueX avatar Feb 06 '23 04:02 FantasqueX