NameplateSCT icon indicating copy to clipboard operation
NameplateSCT copied to clipboard

change: add option to display 1.0M as 1000K

Open S0yKaf opened this issue 1 year ago • 4 comments

This is a change to implement #56

I cleaned up the code a bit in the truncateText function. I also changed the behavior of truncateLetter to be the toggle for the Million display as 1.0M versus 1000K.

in short:

  • [x] Truncate Letter -> 1.0M
  • [ ] Truncate Letter -> 1000K

S0yKaf avatar Sep 02 '24 03:09 S0yKaf

@S0yKaf Why cleaned up L[‘Truncate Letter East Asia’] support for East Asia?

nanjuekaien1 avatar Sep 08 '24 07:09 nanjuekaien1

@S0yKaf Why cleaned up L[‘Truncate Letter East Asia’] support for East Asia?

I just cleaned up the code to be more readable and less redundant. I did not change the functionality.

If the functionality did change, It wasn't my intention. so please let me know if that's the case.

S0yKaf avatar Sep 08 '24 16:09 S0yKaf

@S0yKaf L['Truncate Letter East Asia'] It was added for the localisation of East Asia, which translates to ‘M’ = ‘万’.

nanjuekaien1 avatar Sep 09 '24 06:09 nanjuekaien1

@nanjuekaien1 I understand what I did wrong now. I fixed it

S0yKaf avatar Sep 10 '24 16:09 S0yKaf