SwipeableSplitView icon indicating copy to clipboard operation
SwipeableSplitView copied to clipboard

SplitView Pane enhancements.

Open chrisleyva opened this issue 9 years ago • 7 comments

  1. The SplitView pane is now closed when selecting the previously selected MenuItem.

  2. The swiping gesture logic has been fixed to improve the experience of using the swipable SplitView.

Review on Reviewable

chrisleyva avatar Dec 31 '15 19:12 chrisleyva

I also fixed up the comments in ManipulationCompleted. :-)

I just added punctuation and capitalized the first letter of each. I only modified the comments in that method since it's the only method I modified.

But really nice work on this control. I really like the use of the ListBox, too.

chrisleyva avatar Dec 31 '15 20:12 chrisleyva

Thanks! But looks like the changes you made in the ManipulationCompleted breaks the up and down pan gesture. :(

JustinXinLiu avatar Jan 02 '16 23:01 JustinXinLiu

Also I'd like to keep the code in Shell.xaml.cs and ShellViewModel.cs intact 'cause I actually borrowed them from here.

JustinXinLiu avatar Jan 02 '16 23:01 JustinXinLiu

Sorry. The up and down pan was working for me :-( I tested it quite a bit and I feel like it behaved smoothly.

Also, the link you posted is dead.

chrisleyva avatar Jan 02 '16 23:01 chrisleyva

Sorry, just updated the link.

Try this:

  1. Open the pane and pan to select the last item;
  2. Open the pane again and try to move up your finger just a little bit.

You will notice that the very top item gets highlighted, which is wrong. The 2nd last item should be highlighted instead.

JustinXinLiu avatar Jan 03 '16 00:01 JustinXinLiu

I'll give that a shot. But before my changes, I noticed that both the up/down pan and open/close swipe behaved in an unusual way.

I'll take a look a bit later and see if there is a way to redo my fix without modifying Shell/ShellViewModel and without breaking the up/down pan.

chrisleyva avatar Jan 04 '16 20:01 chrisleyva

Thanks @chrisleyva ! Appreciate your help on this.

JustinXinLiu avatar Jan 04 '16 21:01 JustinXinLiu