zeromq.node
zeromq.node copied to clipboard
JustinTulloss
Fix Appveyor builds
With the default npmversion, the builds only succeed on node 4.
This issue was fixed in npm: https://github.com/nodejs/node-gyp/issues/972
Activate?
Pull requests and Pushes aren't build on appveyor right now. The last build, according to the readme batch, happend 10 months ago: https://ci.appveyor.com/project/reqshark/zeromq-node
You're right. Problem is, I don't have access to this repos settings, @JustinTulloss does. I'll ask again (it's been a while), @JustinTulloss, can I have administrative access on this repo so I can setup hooks for services like Appveyor? Thanks in advance.
I don't know if you need admin access for this or not. Based on the URL @reqshark setup appveypr last time.
oh ya @lgeiger, that's right, let me know if you guys want something done from my side, or even better, anyone can make a new one and use that appveyor to reflect the latest build status ;)
I can't make a new one, because it looks like you need push access to the repo. @reqshark If you login to your appveyor account and add/reactivate this repo everything should work again.
check your email, i added you as collaborator admin, let me know if you need to be user admin
I changed the tracking repository. The build on master works. I'll close and reopen to trigger a new PR build.
@reqshark Thanks for your help. The webhook still doesn't work. Could it be that you don't have push access to this repository anymore?
I see.
@ronkorving, @JustinTulloss To set it up you just have to login to https://ci.appveyor.com/ with your github account and add this repo as a project.
So, I went to that URL, added the project. But indeed, it's under my name. Not under the name of the owner of this repo, which is @JustinTulloss.
I was sure that you'll find JustinTulloss/zeromq.node in that project list. But I'm not very familiar with the appveyor permissions so I might be wrong.
I find it in the list indeed. I did that before. The URL reflected my username, not @JustinTulloss though (but it seems that's normal). I manually started a build, and the latest commit message does seem to reflect the latest on @JustinTulloss (my own fork is out-of-date at this point). But has it set up the hooks? I doubt it.
We ended up bringing our fork of zeromq.node (which was originally in github.com/nteract) over to the zeromq org at https://github.com/zeromq/zeromq.js so we can move forward with making builds easier. Would you like to join the group @ronkorving?
Hey, that sounds great. Let's bring these together. Also, please have a look at my https://github.com/JustinTulloss/zeromq.node/pull/516 branch and let me know (in that PR) what you think.
How far has your fork drifted from this repo?
@ronkorving Great to have you on board! 🎉
The fork of the actual lib hasn't drifted at all. We tried to keep the delta at a minimum. The changes are mostly regarding installation and deployment of prebuilt binaries.
#516 looks very promising but is well out of my expertise. I'm the guy that only solves build issues 😉 😂