linkinator icon indicating copy to clipboard operation
linkinator copied to clipboard

Links containing search params are reported as broken

Open maddsua opened this issue 11 months ago • 4 comments

Simple example: a link like /checkout?services=setup-cctv would be reported as broken. Fixing this should be pretty easy tho. Gotta check the code, and I'll probably create a MR for it

maddsua avatar Mar 21 '24 23:03 maddsua

Oh interesting, so what's broken in my case is a redirect. In fact, that /checkout page is not /checkout.html but at /checkout/index.html. But I don't feel like just slapping a regex replace on top of it, what actually fails is the file server, redirect just doesn't try to prevent it from happening and that's why adding that regex replace fixed it for me

maddsua avatar Mar 21 '24 23:03 maddsua

So, I made a PR that fixes the issue: #596 I mean, I get that you're probably busy with more important things, but it would be nice to get this one done

maddsua avatar Mar 24 '24 11:03 maddsua

Hey @JustinBeckwith, don't want to be annoying or anything but I think that fixing this thing is kinda important

maddsua avatar Apr 05 '24 02:04 maddsua

Hi again! Is there any chance this fix will be merged anytime soon? I mean, it breaks a few of my apps and I would hate to switch to a different link checker just because of that 😂 @JustinBeckwith

maddsua avatar Jun 24 '24 09:06 maddsua