Justin Beckwith comments

Results 124 comments of


                                            Justin Beckwith

Fragment identifiers support

That was a merge on a different repository. I haven't looked at supporting this yet (at least I don't think I did). Happy to review a PR :)

Permanent redirect to from instance to instance/

He @sk- thanks for the details in the bug :) This is super helpful. I think we should explore 2 separate issues here: - Why in the world is the...

Fix Embedded App SDK doc for `setOrientationLockState()`

Thanks for surfacing the issue! Addressed in #6863

Add Koa verify key middleware

Greetings, and thanks for the PR! At this stage, the codebase has significantly moved. Generally I'd like to move this library away from web server specific integrations, so this probably...

createTask requires body to be a buffer

@alexander-fenster To give you the TL;DR of the thread, when you create a new task, it expects you to pass a buffer instead of an object or a string. So...

Import fails after Jest v28 update (Cannot use import statement outside a module)

Yeah I mean if folks want to submit a PR to better support jest, I'm all for it! I just don't really use this package or jest at this point,...

Import fails after Jest v28 update (Cannot use import statement outside a module)

> by default jest assumes that packages in node_modules are CommonJS. .... seriously!? I obviously want to make sure folks can test with this library, but again - CommonJS is...

Retry a gaxios request with new url

Greetings! I can see how something like this is useful, but it's bespoke enough that I wouldn't want to try adding it to the tool. It's a great sign that...

Document `inventory_settings` property

Apologies - this field looks to be flagged as deprecated, and private :/ Closing this out for now.

docs: document incident actions

Note for future me - this is currently flagged as private in our Open API spec, and I need to go figure out why.