pin-tweet-to-ipfs
pin-tweet-to-ipfs copied to clipboard
JusticeEngineering
Work with x.com
Description
It doesn't work with x.com! Well it does now, if https://github.com/webrecorder/save-tweet-now/issues/8 gets fixed. We are visiting the right URL, it's all the backend's fault.
Closes: #269
Checklist
Put an x in the boxes that apply
- [ ] My commit is GPG signed.
- My dog ate my GPG key.
- [ ] ~~If files added, I have modified bundle.sh and esbuild.js to ensure the new files are included in the package~~
- [ ] ~~I have added necessary documentation (if appropriate).~~
Screenshots (Optional)
Concrete proof of it working. Somewhat.
Other information (Optional)
Any other information that is important to this pull request.
The new commit address the issue where image-side display is too narrow to fit the full button:
I simply choose to not emit the span if the available width is less than 2x the min-width of 165 px.
(Honestly in my opinion it should always be the small version, because it just blends better with the bookmark & share buttons that way.)
So on the backend front, manually editing the link from x to twitter like so: https://webrecorder.github.io/save-tweet-now/#url=https%3A%2F%2Ftwitter.com%2Fdimaheve%2Fstatus%2F1844176938895802615&autoupload=1 still works, but it gets stuck at the "pinning to IPFS" step. Should I add this workaround, or wait for them to properly fix the thing?