laravel-transporter icon indicating copy to clipboard operation
laravel-transporter copied to clipboard

`GET` requests don't support query parameters

Open edalzell opened this issue 1 year ago • 2 comments

In getUrl() there's this code:

if (Str::of($this->method)->upper()->contains('GET', 'HEAD')) {
    return $this->path();
}

So any query params set (via withQuery) aren't appended.

I can PR a fix, was this intentional behaviour?

edalzell avatar Apr 25 '23 21:04 edalzell

I would happily accept a PR here! I need to pick up some of the changes I wanted to add to this library

JustSteveKing avatar Apr 26 '23 08:04 JustSteveKing

I would happily accept a PR here! I need to pick up some of the changes I wanted to add to this library

Ya I was going to PR it, then realized I'm on a L9 project and can't go to L10 yet, so I ended up overloading getUrl in my base request class.

edalzell avatar Apr 26 '23 15:04 edalzell

I would happily accept a PR here! I need to pick up some of the changes I wanted to add to this library

@JustSteveKing sorry for the delay, forgot about this, I've PR'ed this.

edalzell avatar Aug 09 '24 00:08 edalzell

Thanks @edalzell 😍

JustSteveKing avatar Aug 09 '24 14:08 JustSteveKing