tenants2 icon indicating copy to clipboard operation
tenants2 copied to clipboard

Some of our markup should be more tolerant of localization

Open toolness opened this issue 4 years ago • 1 comments

Johanna brought up this markup in our letter-courter.tsx file:

          <Trans>
            <NorentLogo size="is-96x96" color="dark">
              NoRent
            </NorentLogo>{" "}
            <span className="subtitle">
              letters sent by tenants across the USA
            </span>
            <p className="is-uppercase">Since April 2020</p>
          </Trans>

In the Spanish localization, she wanted to move the word "letters" before the "NoRent" wordmark so it would read more naturally, but this effectively meant that the word would be outside of <span class="subtitle">, making it smaller than the rest of the text. However, if we change our markup such that all text on either side of the NoRent logo is the same size, then this markup would effectively be "more internationalizable".

toolness avatar May 26 '20 19:05 toolness

Oh interesting! I would also be curious to check and see if we need to add some CSS to the NoRent logo— it could potentially look different rendered inline inside a snipped of text instead of before.

sraby avatar May 27 '20 13:05 sraby