If set default page is invalid, thousands of XHR requests are made

[pointydev]

Description

Related to #1455. If the default page set in Local Storage is set to an invalid value (such as an old installation), navigating to an invalid page causes thousands of XHR requests to be made.

Steps to reproduce

0. (To emulate an old installation, run localStorage["asf-ui:settings:default-view"] = "\"home\"" in console)
1. Navigate to any invalid ASF-ui page, such as the root: http://localhost:1242
2. Observe network activity

Expected behavior

The invalid value is replaced by the default value and network activity is normal.

Current behavior

The invalid value remains, the user is not automatically redirected to a working page, and ~10000 requests to the IPC API can be made in around a minute, even if the user navigates to a working page from there.

Screenshots

Additional information

This behaviour does not present itself on the IPC password screen, only once logged in. Even though this can be easily remedied by manually changing the setting, it may not be apparent to all users, leading to excess resource consumption.

Thanks, Elliott

[Abrynos]

Finally a way to reproduce the issue. 🎉

[Abrynos]

Clarification: We discussed the "thousands of requests" on our discord server previously, but never found a way to reliably reproduce it. Only consensus was that it happend after updating.