MusicBot icon indicating copy to clipboard operation
MusicBot copied to clipboard

Review - Add experimental support for playing local songs

Open ltukezl opened this issue 6 years ago • 3 comments

Please make sure these boxes are checked (put an 'x' inside them) before creating the pull request.

  • [ x] I have tested my changes against the review branch (the latest developmental version), and this pull request is targeting that branch as a base
  • [ x] I have tested my changes on Python 3.5/3.6

Description

+Add support for default music library path +Add support for playing song from bot host machines file system

http://puu.sh/z8Ek8/8aef761533.png http://puu.sh/z8El1/91ca3e7ec8.png !play D:\music lib\frozen synapse\nervous_testpilot - Frozen Synapse Original Soundtrack - 02 Focus.flac

Related issues (if applicable)

some UTF-8 names may break (D:\music libれ ...) no meta data on audio files (plays "untitled" songs) propably more

ltukezl avatar Jan 24 '18 15:01 ltukezl

Hello, I'm very interrested in this PR, could you communicate about what is left to do in order to be merged ?

raspbeguy avatar Jul 21 '18 11:07 raspbeguy

For the most part this repo is in a maintenance only state. We also started to transition to the discord-py libraries rewrite branch, which has a lot of breaking changes so most PRs that interact with the discord-py api won’t work anymore

MattBSG avatar Jul 21 '18 12:07 MattBSG

Something i have in my own test that library printing goes over the 2k character limit and would need better implementation, but i haven't coded a single line since my last PR.

ltukezl avatar Jul 21 '18 12:07 ltukezl

I don't really feel like updating this, sorry for those who want this. OP can reopen if they feel like it and I'll review.

BabyBoySnow avatar Oct 18 '23 02:10 BabyBoySnow