sdk icon indicating copy to clipboard operation
sdk copied to clipboard

Update integration-template to adopt recommendations from recent PR

Open aiwilliams opened this issue 4 years ago • 3 comments

A number of issues came up in an initial integration PR:

  1. Discourage Promise.all by updating the template accordingly: https://github.com/JupiterOne/integration-template/blob/master/src/steps/access.ts#L39

  2. See https://github.com/JupiterOne/integration-template/issues/29 ~~Make jest.config.js require dotenv/config like the Azure integration does. The google-cloud integration does it differently, but it shouldn't be required to have a file like that.~~

  3. Ensure there is an example of doing a recording and snapshot (something like the Artifactory integration does).

aiwilliams avatar Aug 29 '20 20:08 aiwilliams