jupiterbroadcasting.com icon indicating copy to clipboard operation
jupiterbroadcasting.com copied to clipboard

Markdown typo in Office Hours 12

Open CGBassPlayer opened this issue 3 years ago • 3 comments

Office Hours 12 is missing the closing parenthesis on the "JB Live indicator" link

image

Side Note: this did teach us that longer links will not wrap and just run off the screen on mobile image

CGBassPlayer avatar Sep 19 '22 12:09 CGBassPlayer

Adding an html.unescape() resolves the conversion in html2text here in the scraper.py:

        links = html2text(str(links_list)) if links_list else None

ChanceM avatar Sep 19 '22 20:09 ChanceM

So, this is actually something we've already got an issue open about (#221). We were waiting to hear back about if the bug that was submitted to html2text was going to fix the issue. @xPMo was the one who'd said they submitted a bug report upstream. Might want to follow up with that.

@ChanceM, what exactly is that function doing? I haven't looked at that function, but it sounds like (just from the name) that it is just inserting the HTML instead of using MD.

elreydetoda avatar Sep 20 '22 01:09 elreydetoda

So, this is actually something we've already got an issue open about (#221). We were waiting to hear back about if the bug that was submitted to html2text was going to fix the issue. @xPMo was the one who'd said they submitted a bug report upstream. Might want to follow up with that.

@ChanceM, what exactly is that function doing? I haven't looked at that function, but it sounds like (just from the name) that it is just inserting the HTML instead of using MD.

It replaces the escaped sequences like

 " —

with their text equivalents " and —.

ChanceM avatar Sep 20 '22 03:09 ChanceM