atom-julia-client icon indicating copy to clipboard operation
atom-julia-client copied to clipboard

Published 20 hours ago • verified publisher icon JunoLab

recover OS notification

Open aviatesk opened this issue 5 years ago • 3 comments

OS notifications is still an issue ? Searching in atom repo, there seems to be a problem in tree-view stuff in electron<4 on macOS, but couldn't find an issue related to OS notification.

aviatesk avatar Apr 24 '20 11:04 aviatesk

https://github.com/electron/electron/issues/18701 is the upstream issue -- seems like it's only been fixed very recently and I don't think the new Electron version has propagated to Atom yet.

pfitzseb avatar Apr 24 '20 11:04 pfitzseb

okay. Well, do you think we can disable close only on macOS ? I found notifications are swept away after few seconds anyway, so I guess we actually don't need close calls from the beginning, no ?

I started to use Juno for tasks including time consuming computation, and I found I really want this OS notification.

(P.S. I also really can't reproduce the crash on my macOS Mojave 10.14.6 even when calling closes...)

aviatesk avatar Apr 24 '20 12:04 aviatesk

It's probably fine to re-enable this fi we can test it on all platforms and keep it behind a setting.

pfitzseb avatar Apr 24 '20 16:04 pfitzseb