atom-ink icon indicating copy to clipboard operation
atom-ink copied to clipboard

Published 20 hours ago • verified publisher icon JunoLab

Uncaught TypeError: Cannot read property 'props' of undefined

Open tszanalytics opened this issue 6 years ago • 7 comments

[Enter steps to reproduce:]

  1. ...
  2. ...

Atom: 1.40.1 x64 Electron: 3.1.10 OS: Microsoft Windows 10 Enterprise Thrown From: ink package 0.11.0

Stack Trace

Uncaught TypeError: Cannot read property 'props' of undefined

At C:\Users\millsjf\AppData\Local\atom\app-1.40.1\resources\app\static\<embedded>:11

TypeError: Cannot read property 'props' of undefined
    at getKey (/packages/ink/node_modules/etch/lib/patch.js:161:22)
    at mapOldKeysToIndices (/packages/ink/node_modules/etch/lib/patch.js:166:17)
    at updateChildren (/packages/ink/node_modules/etch/lib/patch.js:102:9)
    at patch (/packages/ink/node_modules/etch/lib/patch.js:18:9)
    at updateChildren (/packages/ink/node_modules/etch/lib/patch.js:77:7)
    at patch (/packages/ink/node_modules/etch/lib/patch.js:18:9)
    at updateChildren (/packages/ink/node_modules/etch/lib/patch.js:77:7)
    at patch (/packages/ink/node_modules/etch/lib/patch.js:18:9)
    at updateSync (/packages/ink/node_modules/etch/lib/component-helpers.js:116:20)
    at Object.update (/packages/ink/node_modules/etch/lib/component-helpers.js:62:5)
    at Outline.filterItems (/packages/ink/lib/outline/outline.js:38:12)
    at Outline.setItems (/packages/ink/lib/outline/outline.js:31:10)
    at /packages/julia-client/lib/runtime/outline.js:55:16
    at throttled (/packages/indent-detective/node_modules/underscore/underscore.js:866:23)
    at Function.simpleDispatch (~/AppData/Local/atom/app-1.40.1/resources/app/static/<embedded>:11:1209208)
    at Emitter.emit (~/AppData/Local/atom/app-1.40.1/resources/app/static/<embedded>:11:1210649)
    at TextEditor.cursorMoved (~/AppData/Local/atom/app-1.40.1/resources/app/static/<embedded>:11:33212)
    at Selection.markerDidChange (~/AppData/Local/atom/app-1.40.1/resources/app/static/<embedded>:11:547080)
    at Selection.marker.onDidChange.e (~/AppData/Local/atom/app-1.40.1/resources/app/static/<embedded>:11:532223)
    at Function.simpleDispatch (~/AppData/Local/atom/app-1.40.1/resources/app/static/<embedded>:11:1209208)
    at Emitter.emit (~/AppData/Local/atom/app-1.40.1/resources/app/static/<embedded>:11:1210649)
    at DisplayMarker.notifyObservers (~/AppData/Local/atom/app-1.40.1/resources/app/static/<embedded>:14:2858214)
    at ~/AppData/Local/atom/app-1.40.1/resources/app/static/<embedded>:14:2853716
    at Function.simpleDispatch (~/AppData/Local/atom/app-1.40.1/resources/app/static/<embedded>:11:1209208)
    at Emitter.emit (~/AppData/Local/atom/app-1.40.1/resources/app/static/<embedded>:11:1210649)
    at Marker.emitChangeEvent (~/AppData/Local/atom/app-1.40.1/resources/app/static/<embedded>:14:73563)
    at Marker.update (~/AppData/Local/atom/app-1.40.1/resources/app/static/<embedded>:14:72617)
    at Marker.setHeadPosition (~/AppData/Local/atom/app-1.40.1/resources/app/static/<embedded>:14:68776)
    at DisplayMarker.setHeadBufferPosition (~/AppData/Local/atom/app-1.40.1/resources/app/static/<embedded>:14:2855569)
    at DisplayMarker.setHeadScreenPosition (~/AppData/Local/atom/app-1.40.1/resources/app/static/<embedded>:14:2855801)

Commands

     -3:02.0 julia-client:run-block (input.hidden-input)
     -3:02.0 autocomplete-plus:cancel (atom-text-editor.editor.is-focused)
     -2:29.2.0 julia-client:run-block (input.hidden-input)
     -2:29.2.0 autocomplete-plus:cancel (atom-text-editor.editor.is-focused)
     -2:22.1.0 julia-client:run-block (input.hidden-input)
     -2:22.1.0 autocomplete-plus:cancel (atom-text-editor.editor.is-focused)
     -2:18.4.0 julia-client:run-block (input.hidden-input)
     -2:18.4.0 autocomplete-plus:cancel (atom-text-editor.editor.is-focused)
     -1:30.5.0 julia-client:run-block (input.hidden-input)
     -1:30.5.0 autocomplete-plus:cancel (atom-text-editor.editor.is-focused)
  2x -1:00.7.0 core:backspace (input.hidden-input)
     -0:55.9.0 core:save (input.hidden-input)
     -0:45 core:copy (input.hidden-input)
  6x -0:26 editor:newline (input.hidden-input)
  4x -0:24.2.0 core:move-up (input.hidden-input)
     -0:22.5.0 core:paste (input.hidden-input)

Non-Core Packages

indent-detective 0.4.0 
ink 0.11.0 
julia-client 0.10.1 
language-julia 0.19.1 
latex-completions 0.3.6 
tool-bar 1.1.12 
uber-juno 0.2.0

tszanalytics avatar Oct 01 '19 17:10 tszanalytics

The same is happening to me. Atom is not working at all.

VivaldoMendes avatar Oct 02 '19 12:10 VivaldoMendes

Apparently, the problem only appears when we open a Project. If I open a file, without opening a Project, Atom seems to be working OK.

VivaldoMendes avatar Oct 02 '19 13:10 VivaldoMendes

Can you try updating to ink 0.11.1? Error should be fixed there.

pfitzseb avatar Oct 02 '19 13:10 pfitzseb

Sorry, but the ink package in my Windows 10 computer is already v. 0.11.1.

As I mentioned in my second comment, apparently, the problem only appears if we open up a Project and a file within this project. If I start Atom, and open exactly the same file without expressively opening up the project that contains that file, Atom seems to work with no problems at all.

De: Sebastian Pfitzner [email protected] Enviado: 2 de outubro de 2019 14:11 Para: JunoLab/atom-ink [email protected] Cc: Vivaldo Manuel Mendes [email protected]; Comment [email protected] Assunto: Re: [JunoLab/atom-ink] Uncaught TypeError: Cannot read property 'props' of undefined (#231)

Can you try updating to ink 0.11.1? Error should be fixed there.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/JunoLab/atom-ink/issues/231?email_source=notifications&email_token=ALSE3O75Z7FG7IMQFAKCQN3QMSMZXA5CNFSM4I4MSGEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAEWAQA#issuecomment-537485376, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALSE3O4CZMBP7CEMP6LYJ4DQMSMZXANCNFSM4I4MSGEA.

VivaldoMendes avatar Oct 02 '19 13:10 VivaldoMendes

You most definitely weren't on 0.11.1 when you first posted, I only released that version ~15mins ago ;) Would be good if you could try again after restarting Atom -- I haven't seen that issue since the fix was on master.

pfitzseb avatar Oct 02 '19 13:10 pfitzseb

Yes, you are right. I did the update to ink and now and it works perfectly.

I updated also the other package that could be updated (Tool Bar Menu to v. 1.1.13), and now 4 icons in that toolbar are not displayed:

Start Remote Julia Process Interrupt Julia Stop Julia Run All

They do really work; if we put the cursor on top of the open space that corresponds to their place in the Toolbar their name comes up and they work. The only point is that they can not be seen. It looks like this

[cid:d5f54cc4-b9ae-40c3-b38e-c9d5dbdb3053]

De: Sebastian Pfitzner [email protected] Enviado: 2 de outubro de 2019 14:30 Para: JunoLab/atom-ink [email protected] Cc: Vivaldo Manuel Mendes [email protected]; Comment [email protected] Assunto: Re: [JunoLab/atom-ink] Uncaught TypeError: Cannot read property 'props' of undefined (#231)

You most definitely weren't on 0.11.1 when you first posted, I only released that version ~15mins ago ;) Would be good if you could try again after restarting Atom -- I haven't seen that issue since the fix was on master.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/JunoLab/atom-ink/issues/231?email_source=notifications&email_token=ALSE3O2TTEUKNBVIZ2XPG2TQMSPAZA5CNFSM4I4MSGEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAEX3AY#issuecomment-537492867, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALSE3O5UKWBHRAEOI5BE4LLQMSPAZANCNFSM4I4MSGEA.

VivaldoMendes avatar Oct 02 '19 14:10 VivaldoMendes

Sorry, but following my previous email, the buttons that are not showing up in the Tool Bar Menu, are apparently not working.

I tried to Interrupt Julia and it did not work:

[cid:619d9822-48fe-4379-a336-0b68543efbf5]

De: Vivaldo Manuel Mendes [email protected] Enviado: 2 de outubro de 2019 15:27 Para: JunoLab/atom-ink [email protected] Assunto: RE: [JunoLab/atom-ink] Uncaught TypeError: Cannot read property 'props' of undefined (#231)

Yes, you are right. I did the update to ink and now and it works perfectly.

I updated also the other package that could be updated (Tool Bar Menu to v. 1.1.13), and now 4 icons in that toolbar are not displayed:

Start Remote Julia Process Interrupt Julia Stop Julia Run All

They do really work; if we put the cursor on top of the open space that corresponds to their place in the Toolbar their name comes up and they work. The only point is that they can not be seen. It looks like this

[cid:d5f54cc4-b9ae-40c3-b38e-c9d5dbdb3053]

De: Sebastian Pfitzner [email protected] Enviado: 2 de outubro de 2019 14:30 Para: JunoLab/atom-ink [email protected] Cc: Vivaldo Manuel Mendes [email protected]; Comment [email protected] Assunto: Re: [JunoLab/atom-ink] Uncaught TypeError: Cannot read property 'props' of undefined (#231)

You most definitely weren't on 0.11.1 when you first posted, I only released that version ~15mins ago ;) Would be good if you could try again after restarting Atom -- I haven't seen that issue since the fix was on master.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/JunoLab/atom-ink/issues/231?email_source=notifications&email_token=ALSE3O2TTEUKNBVIZ2XPG2TQMSPAZA5CNFSM4I4MSGEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAEX3AY#issuecomment-537492867, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALSE3O5UKWBHRAEOI5BE4LLQMSPAZANCNFSM4I4MSGEA.

VivaldoMendes avatar Oct 02 '19 15:10 VivaldoMendes