Weave.jl icon indicating copy to clipboard operation
Weave.jl copied to clipboard

Rename the `weave`ed file?

Open likanzhan opened this issue 5 years ago • 3 comments

Is it possible to rename the weaved file when using the weave function? Suppose my original file is a plain index.md file, and I want to render it into a ZZZ.tex file, using weave. I've tried to achieved this via the out_path option, i.e., out_path = ZZZ.tex, but it doesn't work. Any suggestions?

likanzhan avatar Jul 02 '20 13:07 likanzhan

Yeah, I found out_path option is currently just specifying the output directory; we need to modify:

https://github.com/JunoLab/Weave.jl/blob/b5ba227e757520f389a6d6e0f2cacb731eab8b12/src/Weave.jl#L246-L247

aviatesk avatar Aug 17 '20 16:08 aviatesk

This bug has broken the Weave implementation in the VS Code Julia extension (see https://github.com/julia-vscode/julia-vscode/issues/1683#issuecomment-788898402). I had a quick look in the code, and it would be a simple case of modifying https://github.com/JunoLab/Weave.jl/blob/b5ba227e757520f389a6d6e0f2cacb731eab8b12/src/Weave.jl#L247 to give the proper out_path.

But I am not sure if this breaks existing behavior that relies on this bug. Do you guys want me to create a PR?

pgunnink avatar Mar 02 '21 13:03 pgunnink

Yes please. Worst case we could release this as a new major version, but I don't think that'll be necessary.

pfitzseb avatar Mar 02 '21 13:03 pfitzseb