Weave.jl icon indicating copy to clipboard operation
Weave.jl copied to clipboard

use pandoc_jll

Open aviatesk opened this issue 5 years ago • 4 comments

closes #343

currently this is unfunctional, seemingly because of error in pandoc_jll side. (upstream issue: https://github.com/JuliaBinaryWrappers/pandoc_jll.jl/issues/1)

aviatesk avatar Jun 14 '20 11:06 aviatesk

Codecov Report

Merging #375 into master will increase coverage by 2.56%. The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
+ Coverage   71.71%   74.27%   +2.56%     
==========================================
  Files          25       25              
  Lines        1248     1244       -4     
==========================================
+ Hits          895      924      +29     
+ Misses        353      320      -33     
Flag Coverage Δ
#unittests 74.27% <87.50%> (+2.56%) :arrow_up:
Impacted Files Coverage Δ
src/writer/pandoc.jl 57.89% <85.71%> (+57.89%) :arrow_up:
src/rendering/htmlformats.jl 90.74% <100.00%> (+8.92%) :arrow_up:
src/run.jl 81.35% <0.00%> (+1.27%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d8eca00...24d7dcf. Read the comment docs.

codecov-commenter avatar Jun 14 '20 11:06 codecov-commenter

You can also use pandoc_crossref and Tectonic via Yggdrasil. I'm using both in https://github.com/rikhuijzer/Books.jl/blob/main/src/build.jl and they work fine. Feel free to copy code.

rikhuijzer avatar Jul 15 '21 19:07 rikhuijzer

Hey @pfitzseb - following up from a Slack discussion, what can I do to carry this to be successfully merged into Weave? Is this still of interest? I would love to see this merged as I think it would be great for the ecosystem.

TheCedarPrince avatar Dec 06 '21 18:12 TheCedarPrince

I'd recommend opening a PR against this branch that fixes CI (not sure whether pandoc_jll or Tectonic is the better choice though).

pfitzseb avatar Dec 07 '21 10:12 pfitzseb