Weave.jl icon indicating copy to clipboard operation
Weave.jl copied to clipboard

Published 20 hours ago • verified publisher icon JunoLab

undo regression in pre-2.0 pandoc support

Open tlnagy opened this issue 5 years ago • 6 comments

As mentioned in #146, there are a lot of earlier versions of pandoc out there (e.g. the version on Travis is 1.12 AFAIK). This PR adds support back pre-2.0 pandoc support that was eliminated in https://github.com/mpastell/Weave.jl/commit/4cd0b92792e219cb77a42d1a74000234f00b5880.

tlnagy avatar Sep 20 '18 20:09 tlnagy

Coverage Status

Coverage decreased (-0.2%) to 87.115% when pulling 1b7fcad42c974921263b844067274921f2ddd689 on tlnagy:tn/unbreak-pandoc-pre2.0-support into bf57bf8a0717b035afeb030799beb763113a2c2f on mpastell:master.

coveralls avatar Sep 20 '18 20:09 coveralls

Bump @mpastell

tlnagy avatar Oct 18 '18 22:10 tlnagy

Thanks and sorry for leaving this hanging for so long. There are other changes (unfortunately I haven't kept a log of problems I've run into) in pandoc 2.0, at least the same change should apply also to the html output.

mpastell avatar Jan 03 '19 06:01 mpastell

I'm not sure if I understand. This PR fixes the renaming of the --latex-engine flag to --pdf-engine which should only be invoked when generating a PDF?

tlnagy avatar Jan 03 '19 19:01 tlnagy

bump @mpastell. Can I go ahead and merge this small PR adding back PDF support for pandoc <2.0? I think handling edge cases of pandoc 2.0 is a much bigger PR, but I need this to use Weave.jl at all.

tlnagy avatar Jan 08 '19 21:01 tlnagy

Sorry, I looked through it too quickly. Does the format markdown+raw_tex work with pandoc 1.x? I thought it was added in 2.0

mpastell avatar Jan 09 '19 07:01 mpastell