Seal icon indicating copy to clipboard operation
Seal copied to clipboard

Allow installing yt-dlp plugins

Open shifoc opened this issue 1 year ago • 9 comments

Checklist

  • [X] This feature I'm requesting is already implemented in yt-dlp.
  • [ ] This feature is merely a UI/UX update.
  • [ ] This feature is suitable for primary users with little knowledge about yt-dlp.
  • [ ] This feature is available for most websites, not only the video platform I use.
  • [ ] This feature is suitable for a large variety of videos.
  • [X] This feature is not going to conflict with many of the existing options.

Is your feature request related to a problem? Please describe.

No response

Describe the solution you'd like

No response

Video link

No response

Additional context

No response

shifoc avatar Oct 10 '24 21:10 shifoc

App version: 1.13.0 (11300) Device information: Android 13 (API 33) Supported ABIs: [arm64-v8a, armeabi-v7a, armeabi] Yt-dlp version:

URL: https://www.instagram.com/reel/DBKnJy4u2mw/?igsh=dWhpaTQwZ28xODhj WARNING: [Instagram] DBKnJy4u2mw: General metadata extraction failed (some metadata might be missing). WARNING: [Instagram] unable to extract shared data; please report this issue on https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using yt-dlp -U WARNING: [Instagram] Main webpage is locked behind the login page. Retrying with embed webpage (some metadata might be missing). WARNING: [Instagram] unable to extract additional data; please report this issue on https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using yt-dlp -U ERROR: [Instagram] DBKnJy4u2mw: Requested content is not available, rate-limit reached or login required. Use --cookies, --cookies-from-browser, --username and --password, --netrc-cmd, or --netrc (instagram) to provide account credentials

VishweshBhavsar23 avatar Oct 19 '24 02:10 VishweshBhavsar23

I also wanted to do this so I added this functionality to yt-dlp so we can use the new option --plugin-dirs to do this once the nightly build releases

https://github.com/yt-dlp/yt-dlp/pull/11277

imranh2 avatar Oct 20 '24 20:10 imranh2

@imranh2 Cool! Could you tell me what plugin do you want to use?

JunkFood02 avatar Oct 21 '24 03:10 JunkFood02

FYI make sure seal has the All files access/MANAGE_EXTERNAL_STORAGE permission so it can actually read the plugin files and it just works as part of a custom command.

imranh2 avatar Oct 22 '24 02:10 imranh2

@imranh2 Cool! Could you tell me what plugin do you want to use?

personally there are multiple plugins, this is one example: https://github.com/pratikpatel8982/yt-dlp-hianime

shifoc avatar Oct 22 '24 08:10 shifoc

I also wanted to do this so I added this functionality to yt-dlp so we can use the new option --plugin-dirs to do this once the nightly build releases

yt-dlp/yt-dlp#11277

https://github.com/yt-dlp/yt-dlp/releases/tag/2024.10.22 it seems they released it. did you try it yet?

shifoc avatar Oct 22 '24 08:10 shifoc

FYI make sure seal has the All files access/MANAGE_EXTERNAL_STORAGE permission so it can actually read the plugin files and it just works as part of a custom command.

Actually we're planning to remove this permission by the release of v2.0. So we'll need an in-app approach (with some UI) to handle installation/uninstallation of plugins

JunkFood02 avatar Oct 22 '24 08:10 JunkFood02

it seems they released it. did you try it yet?

You can download the source of a plugin, unzip it to a directory and use the new --plugin-dirs in custom commands to use it. (you'll need All files access speciall permission for now)

JunkFood02 avatar Oct 22 '24 08:10 JunkFood02

Actually we're planning to remove this permission by the release of v2.0. So we'll need an in-app approach (with some UI) to handle installation/uninstallation of plugins

A UI approach would be great, until then I just humbly ask you keep the permission around so people can get this to work.

imranh2 avatar Oct 22 '24 17:10 imranh2