OneLauncher icon indicating copy to clipboard operation
OneLauncher copied to clipboard

Fix: Account details saved only after successful game launch

Open DealsBeam opened this issue 2 months ago • 1 comments

Moved the account-saving logic in src/onelauncher/main_window.py to after the game has been launched. This prevents the last_used_world_name from being updated if the game launch is canceled or fails.

Also includes a fix for a Python 3.12 compatibility issue in src/onelauncher/utilities.py.

DealsBeam avatar Nov 01 '25 21:11 DealsBeam

Moved the account-saving logic in src/onelauncher/main_window.py to after the game has been launched. This prevents the last_used_world_name from being updated if the game launch is canceled or fails.

That info is purposefully saved after the account is authenticated but before the game is launched. Can you let me know your reasoning for why you want different behavior?

Also includes a fix for a Python 3.12 compatibility issue in src/onelauncher/utilities.py.

Python 3.12 support requires quite a bit more work than that. Thanks for the thought, though.

I'd also appreciate it if in the future, you can avoid using AI for PRs or at the very least thoroughly review the code.

JuneStepp avatar Nov 02 '25 00:11 JuneStepp