Grid to BlockGrid.. how can we keep fullwidth as a layout?

[mistyn8]

https://github.com/Jumoo/uSyncMigrations/pull/66#issuecomment-1378684563

The "full width" is not converted, since it is not needed, the grid editors marked as allowed in the "row configuration" will marked as referenced, and they are converted from the definitions in grid.editors.config.js

[mistyn8]

@soreng Could you point me to where I'd need to remove the check for a fullwidth grid row configurtion.

For our purposes we need to have a fullwidth migrated to a layout as this has settings applied (to the row) that can't be added to the root block grid container.

Ps did you make any headway on migrating settings?

[soreng]

hi @mistyn8 I haven't done more on my PR since it was reworked by @KevinJump into what is now in the project.

The line you should look into is somewhere around these two:

https://github.com/Jumoo/uSyncMigrations/blob/7ac810dcdf93eb59769ac31973dce9707f34f25e/uSync.Migrations/Migrators/BlockGrid/Config/GridToBlockGridConfigLayoutBlockHelper.cs#L68

https://github.com/Jumoo/uSyncMigrations/blob/7ac810dcdf93eb59769ac31973dce9707f34f25e/uSync.Migrations/Migrators/BlockGrid/Config/GridToBlockGridConfigLayoutBlockHelper.cs#L165

You should be able to apply the settings from you "full width" layout, to blocks added to the root of the grid.

[mistyn8]

thanks @soreng but say we have multiple controls in a fullwidth container from the legacy grid when migrated they end up as floating in the root adding to the block setting is equivalent to adding to the control and not the container.

Settings on full width are required to add say a background to the entire full width rendered row or cell, adding individually to each migrated block produces a different result and becomes unmanageable when you have lots of blocks that would have been in a fullwidth setup. :-)