Julian Waller

Results 535 comments of Julian Waller

Thanks for helping with this. I've been meaning to properly look over what you have done, its similar but probably better written than my attempt #325. I'll read through this...

> Below is a 'typical' end-user's CMake project, consuming the CMakeJS.cmake API, Won't some guidance need to given to cmake on where to find cmakejs still? From reading those docs...

As part of this we should definitely create a bunch of simple example projects which can both be used for unit tests and as example/starter projects for users. There are...

I think thats enough suggested changes for one day, Ill let you look over before looking for more things :) ----- I think there are only cmake lines I had...

> I will probably reflect on your feedback and chip away over the coming days. Perhaps on a new branch if you prefer, to preserve things as they are. I...

> If you do a fresh git clone on this PR, then just run npm/yarn install, the whole thing will 'go'. I'm finding it to be not that simple. There...

So far I am just doing the cleanup I had in suggestions above, to remove any reliance on the existing cmake-js executable https://github.com/nathanjhood/cmake-js/compare/cmakejs_cmake_api...cmake-js:cmake-js:cmakejs_cmake_api Other than that I don't intend to...

> $ npm/yarn run demo:install > CMake output... you will now have an './install' dir containing our "full" CMake API, now fully portable :) Something I am struggling with here...

I wrote most of this on saturday, and haven't looked over any commits/comments made since then, so some of it could be commenting on things that have been changed already....

Thinking about the globbing of headers, from what I managed to find its a problem mostly because it wont detect new files being added. But is that a real concern...