Jules Aguillon

Results 670 comments of Jules Aguillon

The tests are not passing due AST changes, which I think are due to parser-extended not being uptodate.

Merged over https://github.com/ocaml-ppx/ocamlformat/pull/2519

This PR is changed to backport the remaining parser and lexer changes except for `Pexp_function`, which is being worked on in https://github.com/ocaml-ppx/ocamlformat/pull/2544

I would like to review the diff one more time. Since https://github.com/ocaml-ppx/ocamlformat/issues/2440, I plan to not dock empty signatures to avoid breaking the margin. There's also diffs like that, where...

The regressions are huge! I can identify two main regressions: printf/fprintf style functions and operator chains. Printf-style function not only look better with the format string on the same line...

My comment above is not true anymore as I made some changes. Printf-style functions are now formatted like this: (happens a lot) ```diff diff --git a/lib/Conf_decl.ml b/lib/Conf_decl.ml index 031f46ef..fb779cd1 100644...

Thanks for the review! The intent of this is to make explicit a rule that existed before but was implicit. I've added more constraint at the same time in case...

This change is no longer needed to fix a bug since https://github.com/ocaml-ppx/ocamlformat/pull/2445 and https://github.com/ocaml-ppx/ocamlformat/pull/2453 but the new formatting is interesting. I'll keep this open as a draft with the idea...

A different formatting for delimited strings has been implemented in https://github.com/ocaml-ppx/ocamlformat/pull/2480, guarded behind an internal option, using a new `str_as` function.

@gpetiot Thanks, that looks better now. The diff this causes looks good to me but is gigantic. We need to ask for feedback.