Addition, fixes, and improvements on layouts
Armenian and Cyrillic layouts were changed by following way.
- Removed the former Armenian phonetic layout, replacing with a one used in actual typewriters (ՔՎԸՐՏՃ).
- Added the real Armenian typewriter layout (ՃՓԲՍՄՈ).
- Added traditional (pre-revolution) Russian layout (ЙІУКЕН).
- Improved modern Russian layout according to GOST 6431-90 (ЙЦУКЕН).
- Added Russian phonetic layout (ЯВЕРТЫ).
Note: Armenian symbols on Unicode (also formerly on ArmSCII) as "․" (U+2024) and "։" (U+0589) are different from normal "." (U+002E) and ":" (U+003A). Thus the last two were also added on lower section, to make proper experience as navigation on Armenian language domains.
If needed, addition of another layouts are possible, such as Dvorak-style.
@rafasaurus You added the previous Armenian layout in https://github.com/Julow/Unexpected-Keyboard/pull/490 What do you think of the two new Armenian layouts ?
let me build and test, will follow up
Here are some warnings generated by the script:
armn_cpbsmo: Duplicate keys: չ armn_cpbsmo: Layout includes some ASCII punctuation but not all, missing: !, ", #, $, %, &, ', *, +, <, =, >, ?, @, [, ], ^, `, {, }, ~ armn_kvertc: Layout includes some ASCII punctuation but not all, missing: !, ", #, $, %, &, ', *, +, <, =, >, ?, @, [, ], ^, `, {, }, ~ cyrl_jcuken_ru: Layout includes some ASCII punctuation but not all, missing: #, $, &, ', *, <, >, @, [, ], ^, `, {, }, ~ cyrl_jiuken: Layout includes some ASCII punctuation but not all, missing: #, $, &, ', *, +, <, =, >, @, [, ], ^, _, `, {, }, ~ cyrl_yaverti: Layout includes some ASCII punctuation but not all, missing: ~ cyrl_yawerty: Layout includes some ASCII punctuation but not all, missing: #, $, &, ', *, <, >, @, [, ], ^, `, {, }, ~I guess the lack of ASCII punctuations is on purpose ? In that case only the warnings in
armn_cpbsmoandcyrl_yavertimake sense.
Yes. These symbols appearing only on English and other Latin layouts. So not very great idea to overload Russian and Armenian layouts with these symbols. The symbols appeared are the most identical to what was using on actual layouts, as English one has f.e..
I would like to merge this but because you do a lot of things in the same PR, it's hard to review and discuss with other users. Could you propose the new layouts in a separate PR from the changes to existing layouts ?
I would like to merge this but because you do a lot of things in the same PR, it's hard to review and discuss with other users. Could you propose the new layouts in a separate PR from the changes to existing layouts ?
What is hard to review? Every change is explainable, just need to purify.
What is hard to review?
Other contributors might want to have a look at your modifications to the existing layouts but it's not easy because your PR also add several layouts. I suggest that you open a new PR with the added layouts only, so that it can be merged quickly.
What is hard to review?
Other contributors might want to have a look at your modifications to the existing layouts but it's not easy because your PR also add several layouts. I suggest that you open a new PR with the added layouts only, so that it can be merged quickly.
You mean the removed/edited layouts would be here?
You mean the removed/edited layouts would be here?
Yes.
You mean the removed/edited layouts would be here?
Yes.
So a branch for added keyboards was created, so there would be all added layouts, and edited/removed ones would be here.