Sharrre icon indicating copy to clipboard operation
Sharrre copied to clipboard

Published 20 hours ago • verified publisher icon Julienh

Fix Facebook Count

Open njt1982 opened this issue 9 years ago • 5 comments

Applying fix from #294 by @sphism

njt1982 avatar Aug 22 '16 09:08 njt1982

Cheers mate

sphism avatar Aug 22 '16 21:08 sphism

Still showing up issues on my end after replacing the minified file in production.

aandrewjoyce avatar Aug 23 '16 19:08 aandrewjoyce

@aandrewjoyce any errors in console? What happens in the network tab? What's the production URL?

(It's a little hard to debug/help without any more info).

njt1982 avatar Aug 23 '16 21:08 njt1982

@aandrewjoyce have you managed to get any share counts using the graph api explorer?

https://developers.facebook.com/tools/explorer/145634995501895/?method=GET&path=%3Fid%3Dhttp%253A%252F%252Fwww.imdb.com%252Ftitle%252Ftt2015381%252F&version=v2.7

sphism avatar Aug 23 '16 22:08 sphism

on my side, the call was done correctly to facebook, but the info was not displayed. I have found that on some browsers, testing that the resulting json.share object was not empty using json.share.length > 0 was not working. Please see this change https://github.com/AlainVagner/Sharrre/commit/59528271500bd8e7ddf1aff20bc5799a65c7d00a

AlainVagner avatar Sep 14 '16 06:09 AlainVagner