Julien Tant
Julien Tant
Hum interesting turn of event, this new version "breaks" our test, the new version of the library adds a `\n` before some string: ``` Error Trace: /mattermost/server/platform/services/docextractor/pdf_test.go:28 Error: Not equal:...
Thanks for the review @calebroseland! I moved the logic of selecting the current team by default in the selector and it makes the code much easier indeed!
We discussed with @lindy65 offline, we'll defer QA feels more final
> You're welcome!! Would it be better to have no time at all? @JulienTant I think I'd prefer to have no time, but again it's not a big deal :)
> What's the status of this PR, @JulienTant? Do you want me to take a look already? Go ahead! :)
Dear reviewers (@jgheithcock @calebroseland) I'm still fighting big time with the e2e tests but I figured I might as well not wait any longer with reviews 😅
Yes indeed, runs must stay independent! :)