pull-request-name-linter-action
pull-request-name-linter-action copied to clipboard
perf: use a docker image with prebuild commitlint deps
heavily inspired by https://github.com/wagoid/commitlint-github-action I though we could do the same for this linter action.
The npm install step took more than 1 minute in my tests, now the whole action compeltes within 10 seconds :+1:
This PR is not very "cleaned up", I still thought I open it .. and if it's just an inspiration to do the same yourself ;-)
Thanks for your work!
Sider detected 3 warnings on analyzing the commit 2b33484.
We recommend fixing them as possible by updating the dependencies, configuring the analysis tool, configuring sider.yml, turning off unused tools, and so on.
If you have problems or questions still, feel free to ask us via chat. 💬
You can turn off this notification if you don't want to receive it from now on.
Hi @simllll, thanks for submitting this pull request
This look very promising, so by using a docker image this is faster than using a transpiled modules ?
On my custom GitHub runner I do not have docker. Should we have two version ?
- one with docker
- one without docker
No updates on this? I do think that having a pre-build container is extremely useful as most people will not need extra extensions and performance is quite important for something that runs so often.
Maybe we should release two different version of this action, currently people are using it with theirs dependency and it's not pre-build , but I agree to have a pre-build one, when you have the deps that you want inside
also caching node module install can help to make it faster
So what we can do is to have two different action:
- one pre-build with docker
- one that let install the deps yourself (Current behaviour of usage on projects)
Is there any update on this? It would be nice to use on repos that don't contain a config file, this way it will just use the default one and avoids additional install of node.