bentocache icon indicating copy to clipboard operation
bentocache copied to clipboard

[Question] Abandon @poppinss/utils?

Open Zer0xxxx opened this issue 8 months ago • 0 comments

Hello!

I've read the source code some time ago, and if my memories are right, I think that @poppinss/utils is used in bentocache only for its light overload of Lukeed MS?

The issue is that @poppinss/utils doesn't run on the edge properly, except if it has been fixed in the meantime.

I would like to know if it could be considered to just use Lukeed MS and throw if it returns undefined as does the overload of @poppinss/utils?

The plus-value of @poppinss/utils here seems to be really minimal, and breaking edge runtimes just for this seems undesirable to me.

Also, notice that Lukeed MS is historically a fork of vercel/ms, so I guess it would run properly on the edge.

Maybe I'm wrong, sorry, I should read again the repo.


[EDIT] Related to:

  • https://github.com/Julien-R44/bentocache/issues/16

[EDIT] Also see that @poppinss/utils is used in Bentocache to import lodash. I think this could be easily mitigated by just using lodash?

Zer0xxxx avatar Jun 26 '24 00:06 Zer0xxxx