PipelineC icon indicating copy to clipboard operation
PipelineC copied to clipboard

Premature optimization

Open ghost opened this issue 1 year ago • 2 comments

Right now we have areas of code that are intended to be performant, but we don't have benchmarks/profiling in place to know where our hot spots are/whether something is a regression or performance increase.

I suggest for now we allow performance regression and strive for more idiomatic code over performant code. The mypy effort should alleviate performance issues in the long term (mypyc allows 4x speed ups over normal python) and once the code is cleaner in general we can resume optimization with more focus.

Thoughts?

ghost avatar Sep 04 '22 13:09 ghost

I would say leave code as is if it seems done for performance. It should be one of the last things to change.

Focus your changes on easy code that doesn't look highly optimized + new features

JulianKemmerer avatar Sep 04 '22 18:09 JulianKemmerer

Also having examples to point to would be good

JulianKemmerer avatar Sep 04 '22 18:09 JulianKemmerer