Mux.jl icon indicating copy to clipboard operation
Mux.jl copied to clipboard

added https

Open dioptre opened this issue 9 years ago • 2 comments

dioptre avatar Feb 21 '16 10:02 dioptre

Current coverage is 52.13%

Merging #25 into master will increase coverage by +0.32% as of 615af13

@@            master     #25   diff @@
======================================
  Files            7       7       
  Stmts          110     117     +7
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit             57      61     +4
  Partial          0       0       
- Missed          53      56     +3

Review entire Coverage Diff as of 615af13

Powered by Codecov. Updated on successful CI builds.

codecov-io avatar Feb 21 '16 10:02 codecov-io

Thanks for the patch, glad to have this although I think it could be simplified a little (will leave a note).

MikeInnes avatar Feb 22 '16 10:02 MikeInnes

Closing. Mux has changed enough that if we ever support HTTPS, we will have to write a new PR.

cmcaine avatar Sep 05 '23 19:09 cmcaine

Lol, I forgot that we already support HTTPS. Check the tests for example use. An even better reason to close!

cmcaine avatar Sep 05 '23 22:09 cmcaine