Mux.jl icon indicating copy to clipboard operation
Mux.jl copied to clipboard

support assetserving of files with spaces

Open hhaensel opened this issue 5 years ago • 1 comments

Currently assetserving fails when files contain spaces or other url-forbidden characters.

I propose to modify assetserve() in order to solve that issue.

hhaensel avatar Jun 10 '20 15:06 hhaensel

Codecov Report

Merging #105 into master will decrease coverage by 3.38%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
- Coverage   58.21%   54.83%   -3.39%     
==========================================
  Files           7        7              
  Lines         146      155       +9     
==========================================
  Hits           85       85              
- Misses         61       70       +9     
Impacted Files Coverage Δ
src/examples/files.jl 16.12% <0.00%> (-2.39%) :arrow_down:
src/server.jl 70.83% <0.00%> (-3.08%) :arrow_down:
src/websockets_integration.jl 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c3f12af...178b167. Read the comment docs.

codecov-commenter avatar Jun 10 '20 15:06 codecov-commenter

Thanks! Sorry it took so long to get to this :)

cmcaine avatar Sep 05 '23 20:09 cmcaine