HTTP.jl icon indicating copy to clipboard operation
HTTP.jl copied to clipboard

[FEATURE] Could a Logging Feature Be Added to HTTP.jl?

Open TheCedarPrince opened this issue 3 years ago • 3 comments

Version Details:

Please specify the following versions when submitting a bug report:

  • Julia 1.6
  • HTTP.jl 1
  • MbedTLS.jl N/A

Issue Details

This is more of a cross issue from DataDeps.jl based on a discussion there in this issue.@oxinabox said once upon a time that logging of downloads could be possible and that she had it working once upon a time for DataDeps.jl.

@VarshC and I were working on a package today and encountered a situation where her internet was quite spotty - the download from DataDeps didn't stop but it did seem to hang. Having a progress bar option/ability would help give us as users feedback to know if either a download is still happening, paused, or significantly slowed due to poor internet stability.

Is this possible to add into HTTP.jl or outside the scope of this package?

Thanks!

~ tcp :deciduous_tree:

TheCedarPrince avatar Sep 08 '22 15:09 TheCedarPrince

So to clarify, the request here is for logging download progress when using HTTP.download?

quinnj avatar Sep 08 '22 15:09 quinnj

Hi @quinnj - I am sure @oxinabox could comment better but based on the download structure here: https://github.com/oxinabox/DataDeps.jl/blob/master/src/resolution_automatic.jl I believe the answer is yes.

P.S. Jacob you are so insanely fast on this it is amazing. :smile:

TheCedarPrince avatar Sep 08 '22 15:09 TheCedarPrince

This used to work as long as you had a ProgressLogging.jl based logger being used. Which establishes the principle that having a named log argument called progress should be displayed as a progress bar or similar. I believe TerminalLoggers.jl is one such logging package.

It definitely used to work in Juno. And using OhMyLog.jl.

Even without such a logger install HTTP download should be printing a number for progress and a speed and an ETA. It just won't be a bar.

oxinabox avatar Sep 17 '22 19:09 oxinabox