TextAnalysis.jl icon indicating copy to clipboard operation
TextAnalysis.jl copied to clipboard

Published 20 hours ago • verified publisher icon JuliaText

Throw appropriate error for pad_sequence input of length > maxlen

Open Ayushk4 opened this issue 5 years ago • 3 comments

https://github.com/JuliaText/TextAnalysis.jl/blob/f11877268ba3911b30f7b13c549411a08cd380ad/src/sentiment.jl#L4

This function returns nothing in case the input length > maxlen. It will be better to have a proper error handling and err message display for this.

Ayushk4 avatar Jan 10 '20 08:01 Ayushk4

Thanks to @fungktt for pointing out the above.

Ayushk4 avatar Jan 10 '20 08:01 Ayushk4

@Ayushk4 still some work needed on this?

bnriiitb avatar Jul 24 '20 15:07 bnriiitb

I am currently waiting for a response from @sean-gauss , since they already sent a PR.

But, a PR is welcome for fixing this.

Ayushk4 avatar Jul 24 '20 15:07 Ayushk4